Commit 49cfa979 authored by Pavel Emelyanov's avatar Pavel Emelyanov

show: Don't allocate fdset to show thread

Just use the open_image_ro for this.
Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
parent 7241b929
...@@ -596,27 +596,25 @@ static int cr_show_all(unsigned long pid, struct cr_options *opts) ...@@ -596,27 +596,25 @@ static int cr_show_all(unsigned long pid, struct cr_options *opts)
show_core(cr_fdset->fds[CR_FD_CORE], opts->show_pages_content); show_core(cr_fdset->fds[CR_FD_CORE], opts->show_pages_content);
if (item->nr_threads > 1) { if (item->nr_threads > 1) {
struct cr_fdset *cr_fdset_th; int i, fd_th;
int i;
for (i = 0; i < item->nr_threads; i++) { for (i = 0; i < item->nr_threads; i++) {
if (item->threads[i] == item->pid) if (item->threads[i] == item->pid)
continue; continue;
cr_fdset_th = cr_show_fdset_open(item->threads[i], CR_FD_DESC_CORE); fd_th = open_image_ro(CR_FD_CORE, item->threads[i]);
if (!cr_fdset_th) if (fd_th < 0)
goto out; goto out;
pr_msg("\n"); pr_msg("\n");
pr_msg("Thread: %d\n", item->threads[i]); pr_msg("Thread: %d\n", item->threads[i]);
pr_msg("----------------------------------------\n"); pr_msg("----------------------------------------\n");
show_core(cr_fdset_th->fds[CR_FD_CORE], opts->show_pages_content); show_core(fd_th, opts->show_pages_content);
pr_msg("----------------------------------------\n"); pr_msg("----------------------------------------\n");
close_cr_fdset(&cr_fdset_th);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment