crtools: Kill constant arg from parasite_dump_pages_seized

The last one is always CR_FD_PAGES.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>

cr-dump.c

@@ -1118,8 +1118,7 @@ static int dump_one_task(pid_t pid, struct cr_fdset *cr_fdset)
 		goto err;
 	}
 
-	ret = parasite_dump_pages_seized(parasite_ctl, &vma_area_list,
-					 cr_fdset, CR_FD_PAGES);
+	ret = parasite_dump_pages_seized(parasite_ctl, &vma_area_list, cr_fdset);
 	if (ret) {
 		pr_err("Can't dump pages (pid: %d) with parasite\n", pid);
 		goto err;

include/parasite-syscall.h

@@ -37,7 +37,7 @@ extern int syscall_seized(pid_t pid,
 			  user_regs_struct_t *result);
 
 extern int parasite_dump_pages_seized(struct parasite_ctl *ctl, struct list_head *vma_area_list,
-			       struct cr_fdset *cr_fdset, int fd_type);
+			       struct cr_fdset *cr_fdset);
 extern int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct cr_fdset *cr_fdset);
 
 extern struct parasite_ctl *parasite_infect_seized(pid_t pid, void *addr_hint, struct list_head *vma_area_list);

parasite-syscall.c

@@ -388,7 +388,7 @@ out:
  * process) and tells it to dump pages into the file.
  */
 int parasite_dump_pages_seized(struct parasite_ctl *ctl, struct list_head *vma_area_list,
-			       struct cr_fdset *cr_fdset, int fd_type)
+			       struct cr_fdset *cr_fdset)
 {
 	parasite_args_cmd_dumppages_t parasite_dumppages	= { };
 	parasite_args_t parasite_arg				= { };
@@ -400,11 +400,11 @@ int parasite_dump_pages_seized(struct parasite_ctl *ctl, struct list_head *vma_a
 	int status, path_len, ret = -1;
 
 	pr_info("\n");
-	pr_info("Dumping pages (type: %d pid: %d)\n", fd_type, ctl->pid);
+	pr_info("Dumping pages (type: %d pid: %d)\n", CR_FD_PAGES, ctl->pid);
 	pr_info("----------------------------------------\n");
 
-	path_len = strlen(cr_fdset->desc[fd_type].path);
-	pr_info("Dumping pages %s\n", cr_fdset->desc[fd_type].path);
+	path_len = strlen(cr_fdset->desc[CR_FD_PAGES].path);
+	pr_info("Dumping pages %s\n", cr_fdset->desc[CR_FD_PAGES].path);
 
 	if (path_len > sizeof(parasite_dumppages.open_path)) {
 		pr_panic("Dumping pages path is too long (%d while %d allowed)\n",
@@ -412,7 +412,7 @@ int parasite_dump_pages_seized(struct parasite_ctl *ctl, struct list_head *vma_a
 		goto out;
 	}
 
-	if (fchmod(cr_fdset->desc[fd_type].fd, CR_FD_PERM_DUMP)) {
+	if (fchmod(cr_fdset->desc[CR_FD_PAGES].fd, CR_FD_PERM_DUMP)) {
 		pr_perror("Can't change permissions on pages file\n");
 		goto out;
 	}
@@ -421,10 +421,10 @@ int parasite_dump_pages_seized(struct parasite_ctl *ctl, struct list_head *vma_a
 	 * Make sure the data is on disk since we will re-open
 	 * it in another process.
 	 */
-	fsync(cr_fdset->desc[fd_type].fd);
+	fsync(cr_fdset->desc[CR_FD_PAGES].fd);
 
 	strncpy(parasite_dumppages.open_path,
-		 cr_fdset->desc[fd_type].path,
+		 cr_fdset->desc[CR_FD_PAGES].path,
 		 sizeof(parasite_dumppages.open_path));
 
 	parasite_dumppages.open_flags	= O_WRONLY;
@@ -493,7 +493,7 @@ int parasite_dump_pages_seized(struct parasite_ctl *ctl, struct list_head *vma_a
 	pr_info("Summary: %16li pages dumped\n", nrpages_dumped);
 
 err_restore:
-	jerr(fchmod(cr_fdset->desc[fd_type].fd, CR_FD_PERM), out);
+	jerr(fchmod(cr_fdset->desc[CR_FD_PAGES].fd, CR_FD_PERM), out);
 
 out:
 	pr_info("----------------------------------------\n");