Commit d58aafc4 authored by Pavel Emelyanov's avatar Pavel Emelyanov

dump: Don't allocate dfds in case we dump shared fdtable

After patches, that dump locks w/o dfds array, we can even
not allocate one when we don't need it.
Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
parent 2c765509
......@@ -1516,6 +1516,7 @@ static int dump_one_task(struct pstree_item *item)
goto err;
}
if (!shared_fdtable(item)) {
dfds = xmalloc(sizeof(*dfds));
if (!dfds)
goto err;
......@@ -1525,6 +1526,7 @@ static int dump_one_task(struct pstree_item *item)
pr_err("Collect fds (pid: %d) failed with %d\n", pid, ret);
goto err;
}
}
ret = parse_posix_timers(pid, &proc_args);
if (ret < 0) {
......@@ -1597,7 +1599,7 @@ static int dump_one_task(struct pstree_item *item)
goto err_cure;
}
if (!shared_fdtable(item)) {
if (dfds) {
ret = dump_task_files_seized(parasite_ctl, item, dfds);
if (ret) {
pr_err("Dump files (pid: %d) failed with %d\n", pid, ret);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment