Commit 17c67e7e authored by Huachao Huang's avatar Huachao Huang

address comment

parent a5497079
...@@ -2935,18 +2935,6 @@ void crocksdb_user_collected_properties_add(crocksdb_user_collected_properties_t ...@@ -2935,18 +2935,6 @@ void crocksdb_user_collected_properties_add(crocksdb_user_collected_properties_t
props->inner->emplace(std::make_pair(std::string(key, key_len), std::string(value, value_len))); props->inner->emplace(std::make_pair(std::string(key, key_len), std::string(value, value_len)));
} }
struct crocksdb_table_properties_collector_context_t {
void* collector;
const char* (*name)(void*);
void (*destructor)(void*);
void (*add_userkey)(void*,
const char* key, size_t key_len,
const char* value, size_t value_len,
int entry_type, uint64_t seq, uint64_t file_size);
void (*finish)(void*, crocksdb_user_collected_properties_t* props);
void (*readable_properties)(void*, crocksdb_user_collected_properties_t* props);
};
struct crocksdb_table_properties_collector_t : public TablePropertiesCollector { struct crocksdb_table_properties_collector_t : public TablePropertiesCollector {
crocksdb_table_properties_collector_context_t* rep_; crocksdb_table_properties_collector_context_t* rep_;
...@@ -2987,14 +2975,6 @@ struct crocksdb_table_properties_collector_t : public TablePropertiesCollector { ...@@ -2987,14 +2975,6 @@ struct crocksdb_table_properties_collector_t : public TablePropertiesCollector {
} }
}; };
struct crocksdb_table_properties_collector_factory_context_t {
void* factory;
const char* (*name)(void*);
void (*destructor)(void*);
crocksdb_table_properties_collector_context_t*
(*create_table_properties_collector)(void*, uint32_t cf);
};
struct crocksdb_table_properties_collector_factory_t : public TablePropertiesCollectorFactory { struct crocksdb_table_properties_collector_factory_t : public TablePropertiesCollectorFactory {
crocksdb_table_properties_collector_factory_context_t* rep_; crocksdb_table_properties_collector_factory_context_t* rep_;
......
...@@ -117,8 +117,26 @@ typedef struct crocksdb_table_properties_collection_t ...@@ -117,8 +117,26 @@ typedef struct crocksdb_table_properties_collection_t
crocksdb_table_properties_collection_t; crocksdb_table_properties_collection_t;
typedef struct crocksdb_table_properties_collector_factory_t typedef struct crocksdb_table_properties_collector_factory_t
crocksdb_table_properties_collector_factory_t; crocksdb_table_properties_collector_factory_t;
typedef struct crocksdb_table_properties_collector_factory_context_t
crocksdb_table_properties_collector_factory_context_t; typedef struct crocksdb_table_properties_collector_context_t {
void* collector;
const char* (*name)(void*);
void (*destructor)(void*);
void (*add_userkey)(void*,
const char* key, size_t key_len,
const char* value, size_t value_len,
int entry_type, uint64_t seq, uint64_t file_size);
void (*finish)(void*, crocksdb_user_collected_properties_t* props);
void (*readable_properties)(void*, crocksdb_user_collected_properties_t* props);
} crocksdb_table_properties_collector_context_t;
typedef struct crocksdb_table_properties_collector_factory_context_t {
void* factory;
const char* (*name)(void*);
void (*destructor)(void*);
crocksdb_table_properties_collector_context_t*
(*create_table_properties_collector)(void*, uint32_t cf);
} crocksdb_table_properties_collector_factory_context_t;
/* DB operations */ /* DB operations */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment