Commit 5b06e4b7 authored by liugaoling's avatar liugaoling

fix forget to close a response body

parent 605f99f7
...@@ -22,16 +22,16 @@ ...@@ -22,16 +22,16 @@
<artifactId>okhttp</artifactId> <artifactId>okhttp</artifactId>
<version>3.8.1</version> <version>3.8.1</version>
</dependency> </dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.2.10</version>
</dependency>
<dependency> <dependency>
<groupId>commons-lang</groupId> <groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId> <artifactId>commons-lang</artifactId>
<version>2.6</version> <version>2.6</version>
</dependency> </dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.32</version>
</dependency>
</dependencies> </dependencies>
<build> <build>
......
...@@ -44,9 +44,10 @@ public class CloudamClient { ...@@ -44,9 +44,10 @@ public class CloudamClient {
String baseUrl = WorkSpaceFactory.getBaseUrl(this.workSpace); String baseUrl = WorkSpaceFactory.getBaseUrl(this.workSpace);
CloudamResponse cloudamResponse = null; CloudamResponse cloudamResponse = null;
Response response = null;
try { try {
Request.Builder request = cloudamRequest.getBuilder(HttpUtil.getBuilder(this.accessToken), baseUrl, cloudamRequest); Request.Builder request = cloudamRequest.getBuilder(HttpUtil.getBuilder(this.accessToken), baseUrl, cloudamRequest);
Response response = HttpUtil.execNormalHttpRequest(request, 3); response = HttpUtil.execNormalHttpRequest(request, 3);
if (response != null && response.code() == 200 && response.body() != null) { if (response != null && response.code() == 200 && response.body() != null) {
Job job = JSON.parseObject(response.body().bytes(), Job.class); Job job = JSON.parseObject(response.body().bytes(), Job.class);
cloudamResponse = cloudamRequest.getResponseClass().getDeclaredConstructor().newInstance(); cloudamResponse = cloudamRequest.getResponseClass().getDeclaredConstructor().newInstance();
...@@ -54,6 +55,10 @@ public class CloudamClient { ...@@ -54,6 +55,10 @@ public class CloudamClient {
} }
} catch (Exception e) { } catch (Exception e) {
logger.error("Failed to invoke http request from cloudam, method: {}, request param: {}, e:{}", cloudamRequest.getClass().getSimpleName(), JSON.toJSONString(cloudamRequest), e); logger.error("Failed to invoke http request from cloudam, method: {}, request param: {}, e:{}", cloudamRequest.getClass().getSimpleName(), JSON.toJSONString(cloudamRequest), e);
} finally {
if (response != null){
response.close();
}
} }
logger.info("class {}, response:{}", cloudamRequest.getResponseClass(), JSON.toJSONString(cloudamResponse)); logger.info("class {}, response:{}", cloudamRequest.getResponseClass(), JSON.toJSONString(cloudamResponse));
return (T) cloudamResponse; return (T) cloudamResponse;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment