• Kir Kolyshkin's avatar
    arm: rm -Wa from CFLAGS · 70e3b465
    Kir Kolyshkin authored
    Somehow clang doesn't always like -Wa flags, for example when making
    dependencies (see commit 9303ed3 ("Makefiles: move -Wa,--noexecstack
    out of CFLAGS"), which causes build break, scary error messages, and
    even hair loss.
    
    There are many ways to solve this. This patch employs the one
    that is simple and clean.
    
    The -Wa,-mimplicit-it=always flag was added by commit 79c4b747
    ("arm: fix compilation on ARMv7"). The reason is, ARM needs an IT
    instruction before certain conditionals. Those IT instructions are
    almost always automatically generated by assembler itself, but in some
    cases a special assembler flag (like the one above) is needed.
    
    As there is only one place in the code that need IT, it's easy to patch
    it (add explicit IT) and remove the flag. Note that "IT" generates
    no machine code per se, so there should not be any functional change
    (although I haven't checked it).
    
    For more info on IT, see http://tinyurl.com/z3ldsdr
    
    Hope for a review from our ARM experts.
    
    travis-ci: success for Fixes to compile on arm with clang
    Cc: Christopher Covington <cov@codeaurora.org>
    Cc: Dmitry Safonov <dsafonov@virtuozzo.com>
    Cc: Cyrill Gorcunov <gorcunov@openvz.org>
    Signed-off-by: 's avatarKir Kolyshkin <kir@openvz.org>
    Signed-off-by: 's avatarPavel Emelyanov <xemul@virtuozzo.com>
    70e3b465
Makefile 8.42 KB