Commit 31d84043 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Andrei Vagin

zdtm/cgroup_ifpriomap: Fix Coverity warning

*** CID 185302:  Null pointer dereferences  (NULL_RETURNS)
/test/zdtm/static/cgroup_ifpriomap.c: 107 in read_one_priomap()
>>>     Dereferencing a pointer that might be null "out->ifname" when calling "strncpy".

There is also a warning about using rand(), but..
Not sure that we need to entangle everything just for pleasing Coverity:
>>>     CID 185301:  Security best practices violations  (DC.WEAK_CRYPTO)
>>>     "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break.
Leaving that as-is and marking in Coverity as WONTFIX.
Signed-off-by: 's avatarDmitry Safonov <0x7f454c46@gmail.com>
Signed-off-by: 's avatarAndrei Vagin <avagin@virtuozzo.com>
parent 3f6145ad
......@@ -104,6 +104,11 @@ static int read_one_priomap(char *prop_line, struct ifpriomap_t *out)
len = space - prop_line;
out->ifname = malloc(len + 1);
if (!out->ifname) {
pr_perror("malloc() failed\n");
return -1;
}
strncpy(out->ifname, prop_line, len);
out->ifname[len] = '\0'; /* poor man's strlcpy() */
out->prio = (uint32_t)strtol(space + 1, NULL, 10);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment