Commit 3de0f49a authored by Andrew Vagin's avatar Andrew Vagin Committed by Pavel Emelyanov

seize: don't leak a file descriptor

267                     if (stack < 0) {
268                             pr_perror("couldn't log %d's stack", pid);
>>> >>>     CID 164721:  Resource leaks  (RESOURCE_LEAK)
>>> >>>     Variable "f" going out of scope leaks the storage it points to.
269                             return -1;
Signed-off-by: 's avatarAndrew Vagin <avagin@virtuozzo.com>
Signed-off-by: 's avatarPavel Emelyanov <xemul@virtuozzo.com>
parent 93e92223
...@@ -266,6 +266,7 @@ static int log_unfrozen_stacks(char *root) ...@@ -266,6 +266,7 @@ static int log_unfrozen_stacks(char *root)
stack = open_proc(pid, "stack"); stack = open_proc(pid, "stack");
if (stack < 0) { if (stack < 0) {
pr_perror("couldn't log %d's stack", pid); pr_perror("couldn't log %d's stack", pid);
fclose(f);
return -1; return -1;
} }
...@@ -273,6 +274,7 @@ static int log_unfrozen_stacks(char *root) ...@@ -273,6 +274,7 @@ static int log_unfrozen_stacks(char *root)
close(stack); close(stack);
if (ret < 0) { if (ret < 0) {
pr_perror("couldn't read %d's stack", pid); pr_perror("couldn't read %d's stack", pid);
fclose(f);
return -1; return -1;
} }
stackbuf[ret] = '\0'; stackbuf[ret] = '\0';
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment