Commit 5d244ca1 authored by Andrey Vagin's avatar Andrey Vagin Committed by Pavel Emelyanov

cr-check: don't forget close a test socket

CID 996206 (#3 of 3): Resource leak (RESOURCE_LEAK)
8. leaked_handle: Handle variable "sk" going out of scope leaks the handle.
Signed-off-by: 's avatarAndrey Vagin <avagin@openvz.org>
Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
parent 4ef15244
...@@ -398,7 +398,7 @@ static int check_unaligned_vmsplice(void) ...@@ -398,7 +398,7 @@ static int check_unaligned_vmsplice(void)
static int check_so_gets(void) static int check_so_gets(void)
{ {
int sk; int sk, ret = -1;
socklen_t len; socklen_t len;
char name[IFNAMSIZ]; char name[IFNAMSIZ];
...@@ -411,16 +411,19 @@ static int check_so_gets(void) ...@@ -411,16 +411,19 @@ static int check_so_gets(void)
len = 0; len = 0;
if (getsockopt(sk, SOL_SOCKET, SO_GET_FILTER, NULL, &len)) { if (getsockopt(sk, SOL_SOCKET, SO_GET_FILTER, NULL, &len)) {
pr_perror("Can't get socket filter"); pr_perror("Can't get socket filter");
return -1; goto err;
} }
len = sizeof(name); len = sizeof(name);
if (getsockopt(sk, SOL_SOCKET, SO_BINDTODEVICE, name, &len)) { if (getsockopt(sk, SOL_SOCKET, SO_BINDTODEVICE, name, &len)) {
pr_perror("Can't get socket bound dev"); pr_perror("Can't get socket bound dev");
return -1; goto err;
} }
return 0; ret = 0;
err:
close(sk);
return ret;
} }
static int check_ipc(void) static int check_ipc(void)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment