Commit 5ed535f1 authored by Andrey Vagin's avatar Andrey Vagin Committed by Pavel Emelyanov

namespace: append a null byte after readlink

readlink() does not append a null byte to buf.
Signed-off-by: 's avatarAndrey Vagin <avagin@openvz.org>
Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
parent db8ff58f
...@@ -267,7 +267,7 @@ static unsigned int __get_ns_id(int pid, struct ns_desc *nd, struct ns_id **ns) ...@@ -267,7 +267,7 @@ static unsigned int __get_ns_id(int pid, struct ns_desc *nd, struct ns_id **ns)
return 0; return 0;
sprintf(ns_path, "ns/%s", nd->str); sprintf(ns_path, "ns/%s", nd->str);
ret = readlinkat(proc_dir, ns_path, ns_id, sizeof(ns_id)); ret = readlinkat(proc_dir, ns_path, ns_id, sizeof(ns_id) - 1);
if (ret < 0) { if (ret < 0) {
if (errno == ENOENT) { if (errno == ENOENT) {
/* The namespace is unsupported */ /* The namespace is unsupported */
...@@ -277,6 +277,7 @@ static unsigned int __get_ns_id(int pid, struct ns_desc *nd, struct ns_id **ns) ...@@ -277,6 +277,7 @@ static unsigned int __get_ns_id(int pid, struct ns_desc *nd, struct ns_id **ns)
pr_perror("Can't readlink ns link"); pr_perror("Can't readlink ns link");
return 0; return 0;
} }
ns_id[ret] = '\0';
kid = parse_ns_link(ns_id, ret, nd); kid = parse_ns_link(ns_id, ret, nd);
BUG_ON(!kid); BUG_ON(!kid);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment