Commit 92e6a309 authored by Stanislav Kinsbursky's avatar Stanislav Kinsbursky Committed by Pavel Emelyanov

protobuf: simplify plain show logic

__pb_show_msg() is redundant.
Signed-off-by: 's avatarStanislav Kinsbursky <skinsbursky@openvz.org>
Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
parent 0c54b67b
...@@ -58,7 +58,6 @@ extern int pb_write_object_with_header(int fd, void *obj, ...@@ -58,7 +58,6 @@ extern int pb_write_object_with_header(int fd, void *obj,
#include <google/protobuf-c/protobuf-c.h> #include <google/protobuf-c/protobuf-c.h>
extern void pb_show_msg(const void *msg, const void *msg_desc);
extern void do_pb_show_plain(int fd, const ProtobufCMessageDescriptor *d, extern void do_pb_show_plain(int fd, const ProtobufCMessageDescriptor *d,
pb_unpack_t unpack, pb_free_t free); pb_unpack_t unpack, pb_free_t free);
......
...@@ -42,12 +42,12 @@ static void pb_msg_unk(void *obj, void *arg) ...@@ -42,12 +42,12 @@ static void pb_msg_unk(void *obj, void *arg)
pr_msg("unknown object %p\n", obj); pr_msg("unknown object %p\n", obj);
} }
static void __pb_show_msg(const void *msg, const ProtobufCMessageDescriptor *md); static void pb_show_msg(const void *msg, const ProtobufCMessageDescriptor *md);
static void show_nested_message(void *msg, void *md) static void show_nested_message(void *msg, void *md)
{ {
pr_msg("[ "); pr_msg("[ ");
__pb_show_msg(msg, md); pb_show_msg(msg, md);
pr_msg(" ] "); pr_msg(" ] ");
} }
...@@ -132,7 +132,7 @@ static void pb_show_field(const ProtobufCFieldDescriptor *fd, void *where, ...@@ -132,7 +132,7 @@ static void pb_show_field(const ProtobufCFieldDescriptor *fd, void *where,
pr_msg(" "); pr_msg(" ");
} }
static void __pb_show_msg(const void *msg, const ProtobufCMessageDescriptor *md) static void pb_show_msg(const void *msg, const ProtobufCMessageDescriptor *md)
{ {
int i; int i;
...@@ -158,12 +158,6 @@ static void __pb_show_msg(const void *msg, const ProtobufCMessageDescriptor *md) ...@@ -158,12 +158,6 @@ static void __pb_show_msg(const void *msg, const ProtobufCMessageDescriptor *md)
} }
} }
void pb_show_msg(const void *msg, const void *msg_desc)
{
__pb_show_msg(msg, msg_desc);
pr_msg("\n");
}
void do_pb_show_plain(int fd, const ProtobufCMessageDescriptor *md, void do_pb_show_plain(int fd, const ProtobufCMessageDescriptor *md,
pb_unpack_t unpack, pb_free_t free) pb_unpack_t unpack, pb_free_t free)
{ {
...@@ -174,6 +168,7 @@ void do_pb_show_plain(int fd, const ProtobufCMessageDescriptor *md, ...@@ -174,6 +168,7 @@ void do_pb_show_plain(int fd, const ProtobufCMessageDescriptor *md,
break; break;
pb_show_msg(obj, md); pb_show_msg(obj, md);
pr_msg("\n");
free(obj, NULL); free(obj, NULL);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment