Commit d0f53abc authored by Mike Rapoport's avatar Mike Rapoport Committed by Andrei Vagin

lazy-pages: use iov variable name for lazy_iov

travis-ci: success for lazy-pages: add non-#PF events handling (rev2)
Signed-off-by: 's avatarMike Rapoport <rppt@linux.vnet.ibm.com>
Signed-off-by: 's avatarPavel Emelyanov <xemul@virtuozzo.com>
parent 8c496f4f
...@@ -316,11 +316,11 @@ static MmEntry *init_mm_entry(struct lazy_pages_info *lpi) ...@@ -316,11 +316,11 @@ static MmEntry *init_mm_entry(struct lazy_pages_info *lpi)
static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr, static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr,
int len) int len)
{ {
struct lazy_iov *lazy_iov, *n; struct lazy_iov *iov, *n;
list_for_each_entry_safe(lazy_iov, n, &lpi->iovs, l) { list_for_each_entry_safe(iov, n, &lpi->iovs, l) {
unsigned long start = lazy_iov->base; unsigned long start = iov->base;
unsigned long end = start + lazy_iov->len; unsigned long end = start + iov->len;
if (len <= 0) if (len <= 0)
break; break;
...@@ -337,12 +337,12 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr, ...@@ -337,12 +337,12 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr,
*/ */
if (addr + len < end) { if (addr + len < end) {
if (addr == start) { if (addr == start) {
lazy_iov->base += len; iov->base += len;
lazy_iov->len -= len; iov->len -= len;
} else { } else {
struct lazy_iov *new_iov; struct lazy_iov *new_iov;
lazy_iov->len -= (end - addr); iov->len -= (end - addr);
new_iov = xzalloc(sizeof(*new_iov)); new_iov = xzalloc(sizeof(*new_iov));
if (!new_iov) if (!new_iov)
...@@ -351,7 +351,7 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr, ...@@ -351,7 +351,7 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr,
new_iov->base = addr + len; new_iov->base = addr + len;
new_iov->len = end - (addr + len); new_iov->len = end - (addr + len);
list_add(&new_iov->l, &lazy_iov->l); list_add(&new_iov->l, &iov->l);
} }
break; break;
} }
...@@ -363,10 +363,10 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr, ...@@ -363,10 +363,10 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr,
* and continue to the next one with the updated range * and continue to the next one with the updated range
*/ */
if (addr == start) { if (addr == start) {
list_del(&lazy_iov->l); list_del(&iov->l);
xfree(lazy_iov); xfree(iov);
} else { } else {
lazy_iov->len -= (end - addr); iov->len -= (end - addr);
} }
len -= (end - addr); len -= (end - addr);
...@@ -387,7 +387,7 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr, ...@@ -387,7 +387,7 @@ static int update_lazy_iovs(struct lazy_pages_info *lpi, unsigned long addr,
static int collect_lazy_iovs(struct lazy_pages_info *lpi) static int collect_lazy_iovs(struct lazy_pages_info *lpi)
{ {
struct page_read *pr = &lpi->pr; struct page_read *pr = &lpi->pr;
struct lazy_iov *lazy_iov, *n; struct lazy_iov *iov, *n;
MmEntry *mm; MmEntry *mm;
int nr_pages = 0, n_vma = 0, max_iov_len = 0; int nr_pages = 0, n_vma = 0, max_iov_len = 0;
int ret = -1; int ret = -1;
...@@ -411,14 +411,14 @@ static int collect_lazy_iovs(struct lazy_pages_info *lpi) ...@@ -411,14 +411,14 @@ static int collect_lazy_iovs(struct lazy_pages_info *lpi)
if (start >= vma->end) if (start >= vma->end)
continue; continue;
lazy_iov = xzalloc(sizeof(*lazy_iov)); iov = xzalloc(sizeof(*iov));
if (!lazy_iov) if (!iov)
goto free_iovs; goto free_iovs;
len = min_t(uint64_t, end, vma->end) - start; len = min_t(uint64_t, end, vma->end) - start;
lazy_iov->base = start; iov->base = start;
lazy_iov->len = len; iov->len = len;
list_add_tail(&lazy_iov->l, &lpi->iovs); list_add_tail(&iov->l, &lpi->iovs);
if (len > max_iov_len) if (len > max_iov_len)
max_iov_len = len; max_iov_len = len;
...@@ -437,8 +437,8 @@ static int collect_lazy_iovs(struct lazy_pages_info *lpi) ...@@ -437,8 +437,8 @@ static int collect_lazy_iovs(struct lazy_pages_info *lpi)
goto free_mm; goto free_mm;
free_iovs: free_iovs:
list_for_each_entry_safe(lazy_iov, n, &lpi->iovs, l) list_for_each_entry_safe(iov, n, &lpi->iovs, l)
xfree(lazy_iov); xfree(iov);
free_mm: free_mm:
mm_entry__free_unpacked(mm, NULL); mm_entry__free_unpacked(mm, NULL);
...@@ -632,16 +632,16 @@ static int uffd_handle_pages(struct lazy_pages_info *lpi, __u64 address, int nr, ...@@ -632,16 +632,16 @@ static int uffd_handle_pages(struct lazy_pages_info *lpi, __u64 address, int nr,
static int handle_remaining_pages(struct lazy_pages_info *lpi) static int handle_remaining_pages(struct lazy_pages_info *lpi)
{ {
struct lazy_iov *lazy_iov; struct lazy_iov *iov;
int nr_pages, err; int nr_pages, err;
if (list_empty(&lpi->iovs)) if (list_empty(&lpi->iovs))
return 0; return 0;
lazy_iov = list_first_entry(&lpi->iovs, struct lazy_iov, l); iov = list_first_entry(&lpi->iovs, struct lazy_iov, l);
nr_pages = lazy_iov->len / PAGE_SIZE; nr_pages = iov->len / PAGE_SIZE;
err = uffd_handle_pages(lpi, lazy_iov->base, nr_pages, 0); err = uffd_handle_pages(lpi, iov->base, nr_pages, 0);
if (err < 0) { if (err < 0) {
pr_err("Error during UFFD copy\n"); pr_err("Error during UFFD copy\n");
return -1; return -1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment