Commit dc80d6f1 authored by Ruslan Kuprieiev's avatar Ruslan Kuprieiev Committed by Pavel Emelyanov

log: get rid of LOG_DIR_FD_OFF and opening cwd in log_init()

Signed-off-by: 's avatarRuslan Kuprieiev <kupruser@gmail.com>
Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
parent 127637bc
...@@ -870,7 +870,6 @@ static int restore_one_task(int pid, CoreEntry *core) ...@@ -870,7 +870,6 @@ static int restore_one_task(int pid, CoreEntry *core)
int ret; int ret;
/* No more fork()-s => no more per-pid logs */ /* No more fork()-s => no more per-pid logs */
log_closedir();
switch ((int)core->tc->task_state) { switch ((int)core->tc->task_state) {
case TASK_ALIVE: case TASK_ALIVE:
......
...@@ -124,8 +124,6 @@ static int setup_opts_from_req(int sk, CriuOpts *req) ...@@ -124,8 +124,6 @@ static int setup_opts_from_req(int sk, CriuOpts *req)
if (open_image_dir(".") < 0) if (open_image_dir(".") < 0)
return -1; return -1;
log_closedir();
/* initiate log file in imgs dir */ /* initiate log file in imgs dir */
if (req->log_file) if (req->log_file)
opts.output = req->log_file; opts.output = req->log_file;
......
...@@ -7,7 +7,6 @@ enum sfd_type { ...@@ -7,7 +7,6 @@ enum sfd_type {
SERVICE_FD_MIN, SERVICE_FD_MIN,
LOG_FD_OFF, LOG_FD_OFF,
LOG_DIR_FD_OFF,
IMG_FD_OFF, IMG_FD_OFF,
PROC_FD_OFF, /* fd with /proc for all proc_ calls */ PROC_FD_OFF, /* fd with /proc for all proc_ calls */
CTL_TTY_OFF, CTL_TTY_OFF,
......
...@@ -63,29 +63,13 @@ int log_get_fd(void) ...@@ -63,29 +63,13 @@ int log_get_fd(void)
int log_init(const char *output) int log_init(const char *output)
{ {
int new_logfd, dfd, fd; int new_logfd, fd;
gettimeofday(&start, NULL); gettimeofday(&start, NULL);
buf_off = TS_BUF_OFF; buf_off = TS_BUF_OFF;
dfd = get_service_fd(LOG_DIR_FD_OFF);
if (dfd < 0) {
int tmp;
tmp = open(".", O_RDONLY);
if (tmp == -1) {
pr_perror("Can't open a current directory");
return -1;
}
dfd = install_service_fd(LOG_DIR_FD_OFF, tmp);
close(tmp);
if (dfd < 0)
return -1;
}
if (output) { if (output) {
new_logfd = openat(dfd, output, new_logfd = open(output, O_CREAT|O_TRUNC|O_WRONLY|O_APPEND, 0600);
O_CREAT | O_TRUNC | O_WRONLY | O_APPEND, 0600);
if (new_logfd < 0) { if (new_logfd < 0) {
pr_perror("Can't create log file %s", output); pr_perror("Can't create log file %s", output);
return -1; return -1;
...@@ -137,12 +121,6 @@ int log_init_by_pid(void) ...@@ -137,12 +121,6 @@ int log_init_by_pid(void)
void log_fini(void) void log_fini(void)
{ {
close_service_fd(LOG_FD_OFF); close_service_fd(LOG_FD_OFF);
log_closedir();
}
void log_closedir(void)
{
close_service_fd(LOG_DIR_FD_OFF);
} }
void log_set_loglevel(unsigned int level) void log_set_loglevel(unsigned int level)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment