Skip to content
Commit dd71cca5 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Pavel Emelyanov
Browse files

dump/x86: sanitize the ERESTART_RESTARTBLOCK -> EINTR transition



1. The -ERESTART_RESTARTBLOCK case in get_task_regs() depends on kernel
   internals too much, and for no reason. We shouldn't rely on fact that
   a) we are going to do sigreturn() and b) restore_sigcontext() always
   sets restart_block->fn = do_no_restart_syscall which returns -EINTR.

   Just change this code to enforce -EINTR after restore, this is what
   we actually want until we teach criu to handle ERESTART_RESTARTBLOCK.

2. Add pr_warn() to make the potential bug-reports more understandable,
   a sane application should handle -EINTR correctly but this is not
   always the case.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarCyrill Gorcunov <gorcunov@openvz.org>
Acked-by: default avatarAndrew Vagin <avagin@parallels.com>
Signed-off-by: default avatarPavel Emelyanov <xemul@parallels.com>
parent 81a4d3b2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment