Commit eb329f09 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Andrei Vagin

compel: do not pass DEFINES two times to HOSTCFLAGS

I think, it's more pretty to pass -DCONFIG_X86_* instead of all
$DEFINES. That simplifies the statement and makes it more readable.

Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: 's avatarDmitry Safonov <dsafonov@virtuozzo.com>
Acked-by: 's avatarCyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: 's avatarPavel Emelyanov <xemul@virtuozzo.com>
Signed-off-by: 's avatarAndrei Vagin <avagin@virtuozzo.com>
parent ce5cd693
...@@ -6,7 +6,7 @@ ccflags-y += -iquote compel/arch/$(ARCH)/include ...@@ -6,7 +6,7 @@ ccflags-y += -iquote compel/arch/$(ARCH)/include
ccflags-y += -DCOMPEL_VERSION=\"$(COMPEL_SO_VERSION_MAJOR).$(COMPEL_SO_VERSION_MINOR)\" ccflags-y += -DCOMPEL_VERSION=\"$(COMPEL_SO_VERSION_MAJOR).$(COMPEL_SO_VERSION_MINOR)\"
host-ccflags-y += $(filter-out -pg $(CFLAGS-GCOV),$(ccflags-y)) host-ccflags-y += $(filter-out -pg $(CFLAGS-GCOV),$(ccflags-y))
HOSTCFLAGS += $(filter-out -pg $(CFLAGS-GCOV),$(WARNINGS) $(DEFINES)) HOSTCFLAGS += $(filter-out -pg $(CFLAGS-GCOV),$(WARNINGS) $(filter-out -DCONFIG_X86_64,$(DEFINES)))
HOSTLDFLAGS += $(filter-out -pg $(CFLAGS-GCOV),$(LDFLAGS)) HOSTLDFLAGS += $(filter-out -pg $(CFLAGS-GCOV),$(LDFLAGS))
hostprogs-y += compel hostprogs-y += compel
...@@ -14,16 +14,13 @@ compel-objs += main.o ...@@ -14,16 +14,13 @@ compel-objs += main.o
compel-objs += handle-elf.o compel-objs += handle-elf.o
compel-objs += arch/$(ARCH)/handle-elf.o compel-objs += arch/$(ARCH)/handle-elf.o
# Add $(DEFINES) to CFLAGS of compel-objs. ifeq ($(ARCH),x86)
# We can't do ccflags-y += $(DEFINES) # Add -DCONFIG_X86_64 or -DCONFIG_X86_32 to HOSTCFLAGS
# as we need to build handle-elf-32.o
# with -DCONFIG_X86_32
define ccflags-defines define ccflags-defines
HOSTCFLAGS_$(notdir $(1)) += $(DEFINES) HOSTCFLAGS_$(notdir $(1)) += -DCONFIG_X86_64
endef endef
$(eval $(call map,ccflags-defines,$(compel-objs))) $(eval $(call map,ccflags-defines,$(compel-objs)))
ifeq ($(ARCH),x86) compel-objs += handle-elf-32.o
compel-objs += handle-elf-32.o HOSTCFLAGS_handle-elf-32.o += -DCONFIG_X86_32
HOSTCFLAGS_handle-elf-32.o += -DCONFIG_X86_32 endif # ARCH == x86
endif
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment