- 04 May, 2013 1 commit
-
-
Libo Chen authored
Avoid memleak in err case Signed-off-by:
Libo Chen <libo.chen@huawei.com> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
- 02 May, 2013 34 commits
-
-
Kir Kolyshkin authored
Signed-off-by:
Kir Kolyshkin <kir@openvz.org> Signed-off-by:
-
Kir Kolyshkin authored
Note to package maintainers: 1 Yes we do support DESTDIR. 2 From packaging scripts, use something like this: make install DESTDIR=$RPM_BUILD_ROOT PREFIX=/usr (v2: add PREFIX, install to /usr/local not /usr by default) (v3: fix criu man section -- it is 8 not 1) Signed-off-by:
-
Libo Chen authored
Without this patch, ifd will leak when inotify_add_watch fail. Signed-off-by:
-
Libo Chen authored
Without this patch, fd will leak when epoll_create fail! Signed-off-by:
-
Kir Kolyshkin authored
Let's save 4 lines of output and put -vvv at the same line as -v 3. Also, -v argument is in fact option, so mark it as such: [NUM] Signed-off-by:
-
Kir Kolyshkin authored
From where I stand, any help output that exceeds 80 columns is hardly readable, so let's try to fit into that. Apparently in many cases we can do that by removing some extra info which, I guess, belongs to documentation or wiki but not to --help output which should be just a short reference. For this reason, this patch also removes information about environmental variable set for external scripts -- such documentation does not belong here. Please review carefully to make sure I haven't thrown the baby out with the bathwater. Signed-off-by:
-
Kir Kolyshkin authored
1. "written in file" -> "written to file" 2. "relative path is relative" -> "path is relative" 3. "each restored processes is written to the FILE.pid file\n" -> "log of each restored process is written to a separate FILE.pid file" Signed-off-by:
-
Kir Kolyshkin authored
Alternatively, we could add [<options>] but since this is the only option let's just add this one. Signed-off-by:
-
Kir Kolyshkin authored
1. Now either <arg> or ARG or [ARG] were used to denote an option argument. Let's be consistent and use ARG everywhere. An alternative could be be <arg>, but I'm strongly against [ARG] since square brackets traditionally denote something that is optional. 2. If argument is a file name, use FILE, not NAME or SRC 3. For options that require argument, add argument. List includes: -t|--tree -D|--images-dir (twice) -f|--file Maybe I missed something else, hopefully not. Signed-off-by:
-
Kir Kolyshkin authored
Some lines were using tabs, some were not. Personally I am not in favor of any style, but let's be consistent in either using tabs or not. Changing tabs with spaces produced a smaller patch, so let's do this way. This patch should not produce any visual change in output. Signed-off-by:
-
Kir Kolyshkin authored
This patch reformats the source to print extended help using just one pr_msg command. Having it this way is easier to do further edits. I have checked ./criu --help output before and after to make sure it's the same. Signed-off-by:
-
Kir Kolyshkin authored
... in quite a few places. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Kir Kolyshkin authored
1. s/pid 1234/pid of 1234/ 2. Remove all those "one should type" or "run". Signed-off-by:
-
Kir Kolyshkin authored
Either we list all options in synopsys, or none. Signed-off-by:
-
Kir Kolyshkin authored
Also, s/options/arguments/. Signed-off-by:
-
Kir Kolyshkin authored
A manual page is formal document, not a chitchat, so use of contracted forms is not appropriate. Signed-off-by:
-
Kir Kolyshkin authored
allpies -> applies Signed-off-by:
-
Kir Kolyshkin authored
Literals in bold, variables in italic. Signed-off-by:
-
Kir Kolyshkin authored
1. Use *bold* for option names. 2. Separate long and short option by a comma and a space. Signed-off-by:
-
Kir Kolyshkin authored
1. Move commands out of OPTIONS subsection. 2. Don't use bulleted list -- definition list (such as in OPTIONS) is better. Also follwong -> following Signed-off-by:
-
Kir Kolyshkin authored
It's actually not very complicated. Just do this: 1 For literals (verbal text, such as command or option name) use *bold* 2 For substitutions (variable parameter name) use 'italic' 3 Do not use <angle brackets> at all. Example: *-f* 'file' Signed-off-by:
-
Kir Kolyshkin authored
This command is for root, so section 8 of manual is more appropriate than 1. Signed-off-by:
-
Kir Kolyshkin authored
1 It should be COPYRIGHT not COPYING 2 Happy New Year! Signed-off-by:
-
Kir Kolyshkin authored
It's a common practice. Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
Be green -- save bytes! Signed-off-by:
-
Kir Kolyshkin authored
When silent make rules are enabled, we use special format to inform what is going on, like this $(E) " ACTION " files We maintain specific whitespace around ACTION so different ones are aligned nicely. Fix two places that were not aligned to the rest. Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
$(E) is used for 'silent make' to inform about what is going on when we are not printing actual commands being executed, and do nothing in case of 'verbose make (i.e. make V=1). For 'make help' we want to output the text regardless of whether 'silent make' is enabled or not. Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
This is developers documentation, I doubt any user of crui is interested in that. So let's not build it by default. It can still be built manually: make -C Documentation Makefile.build.1 Signed-off-by:
-
Kir Kolyshkin authored
...using "git archive" command line from Pavel. Signed-off-by:
-
- 30 Apr, 2013 5 commits
-
-
Pavel Emelyanov authored
This is lots-of-bug-fixes release -- many new people started playing with criu and reported a lot of issues with it. Other than this, we have several new features. First of all it's C/R of netlink sockets C/R (required for Fedora container dump) and pending signals. Next, we've changed the format of memory dumps. This allowed us to implement so called page server, that allows to send memory dumps directly on another box w/o intermediate dump file. Also this new format made it possible to implement the (not yet final) --snapshot option, that demonstrates the work of user memory changes tracker in the kernel. Signed-off-by: -
Kir Kolyshkin authored
"Tools" in the context of a binary name doesn't make any sense, because every binary is a tool (lstool, dftool), plus it's one tool. So let's rename the beast to criu, which is short, pretty unique and coincides with the name of the project. Backward-compatible symlink is added for the sake of tests, we can fix them later and remove the link. Packagers beware: our binary is no longer crtools but criu. Signed-off-by:
-
Cyrill Gorcunov authored
We don't use tabs in docs. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
