Commits · 3a9c6a3d375bcf0544429c8e3571f8a073d05ba8 · zhul / criu

07 May, 2014 2 commits

util: use glibc macros to generate device numbers in the dev_t format · 3a9c6a3d

Andrey Vagin authored May 05, 2014

Our version of macroses are worng.

Our macros:
#define MINOR(dev)           ((dev) & 0xff)

Glibc function:
return (__dev & 0xff) | ((unsigned int) (__dev >> 12) & ~0xff);
Reported-by: Amey Deshpande <ameyd@google.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

3a9c6a3d

page-pipe: Don't increase the page_pipe::nr_pipes if we reuse pipes · 74a2cce1

Cyrill Gorcunov authored May 06, 2014

The page-pipe buffers may be reused once queued pages are
dumped, but we happen to increase page_pipe::nr_pipes
all the timer, regardless the fact where page buffer
came from.

In worst scenario this may lead to incorrect -EAGAIN returned
from page_pipe_grow forcing calling code to create new
pipes. This is not critical but should be fixed.

In other words page_pipe::nr_pipes must track _really_
created pipes.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

74a2cce1

25 Apr, 2014 4 commits

criu: Version 1.3-rc1 · 54a996b0

Pavel Emelyanov authored Apr 25, 2014

We have made big step towards C/R of LXC containers -- made support
for nested mount namespaces and addressed the re-attach issue. Also
we have AArch64 support merged.

Some work is still to be done, but it's good time to show what we
have so far, thus -- the 1.3-rc1.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

54a996b0

Don't say /proc in macro errors · 5d74f55d

Christopher Covington authored Apr 24, 2014

It's possible that a procfs mounted somewhere other than /proc
is in use.
Signed-off-by: Christopher Covington <cov@codeaurora.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

5d74f55d

log: Include inttypes.h for PRI helpers · 0c89d779

Cyrill Gorcunov authored Apr 24, 2014

https://bugzilla.openvz.org/show_bug.cgi?id=2949Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

0c89d779

check: skip mnt_id support check for mainstream kernels (v2) · 74c0e9e2

Andrey Vagin authored Apr 25, 2014

v2: s/tun/mnt_id
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

74c0e9e2

24 Apr, 2014 1 commit

zdtm: check mnt_id in /proc/PID/fdinfo/X · 08960eb1

Andrey Vagin authored Apr 23, 2014

Nested mount namespaces should be checked only if fdinfo contains mnt_id
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

08960eb1

23 Apr, 2014 5 commits

mnt: Get ns temp root path once when collecting data from image · d4e4e577
Pavel Emelyanov authored Apr 23, 2014
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
d4e4e577
zdtm: Add testing of irmap cache generation · 5975c94e
Pavel Emelyanov authored Apr 23, 2014
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
5975c94e

ns: initialize nsid in rst_add_ns_id · a20011ac

Andrey Vagin authored Apr 23, 2014

Execute zdtm/live/static/pipe00
./pipe00 --pidfile=pipe00.pid --outfile=pipe00.out
Dump 3158
Restore
test/zdtm.sh: line 472:  3173 Segmentation fault      (core dumped) setsid  restore --file-locks --tcp-established -x -D  -o

Reported-by: Jenkins Criuovich
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

a20011ac

mnt: Factor out mntns nsid creation on restore · 8d5822d9
Pavel Emelyanov authored Apr 23, 2014
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
8d5822d9
mnt: Add comment why we need criu's mntns mounts for dump · aca33ac4
Pavel Emelyanov authored Apr 23, 2014
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
aca33ac4

22 Apr, 2014 28 commits

files: Check for for mount to exist only once · f22591c9

Pavel Emelyanov authored Apr 22, 2014

The nsid lookup will search for mount in case mnt_id
is given. No need to do it twice (the 2nd time for
sanity check).
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f22591c9

unix: Get ns root fd only once. · 74357818

Pavel Emelyanov authored Apr 22, 2014

This makes mntns_get_root_fd usage more natural.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

74357818

mnt: Add comments on tricky places · 8ef1d378
Pavel Emelyanov authored Apr 22, 2014
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
8ef1d378
mnt: Sanitize prepare_mnt_ns nsids loop · 3d11c6c0
Pavel Emelyanov authored Apr 22, 2014
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
3d11c6c0

mnt: Turn mntns_get_root_fd into accepting mnt ns_id · 68e2841a

Pavel Emelyanov authored Apr 22, 2014

The only exception (for now) is the irmap -- it should
operate on ns as well.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

68e2841a

remap: Keep nsid on remap rollback, not the ns' pid · 1c4f8fdc

Pavel Emelyanov authored Apr 22, 2014

This is more logical -- we should remap file in namespace,
not in pid. Also this would help to clean the code further.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

1c4f8fdc

Revert "mnt: Merge two calls to collect_mntinfo on early restore" · d5e6a51b

Pavel Emelyanov authored Apr 22, 2014

This reverts commit f55a0b91.

The collected mounts list a) points to nsid and b) should be
put on nsid's mntinfo_tree. Thus is _should_ be done by separate
calls.

d5e6a51b

mnt: Rename _collect_root into _get_root_fd · 1435617c

Pavel Emelyanov authored Apr 22, 2014

Nowadays this routine is mainly used for getting an
fd, rather than keeping one for future reference.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

1435617c

mount: remove extra calls of mntns_collect_root() · 20003300

Andrey Vagin authored Apr 22, 2014

Now mntns_collect_root() should be called each time when we need to get
a root of a specified namespace and we don't need to call it for
initializing the global variable.
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

20003300

rst: Don't lookup ns if current mntns is the same as root's one · 4ec63d53
Pavel Emelyanov authored Apr 22, 2014
```
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
4ec63d53

rst: Less arguments to restore_task_mnt_ns · 79f3e908

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

79f3e908

rst: Don't forget to close nsfd after setns · 8472345d

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

8472345d

mnt: Merge two calls to collect_mntinfo on early restore · f55a0b91
Pavel Emelyanov authored Apr 22, 2014
```
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
f55a0b91
mnt: Move local mntns collecting on restore into prepare_mnt_ns · 8550f520
Pavel Emelyanov authored Apr 22, 2014
```
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
8550f520

mnt: Move nsmask checking into prepare_mnt_ns · 05c02ddc

Pavel Emelyanov authored Apr 22, 2014

Helper for simpler next patch.
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

05c02ddc

mnt: Sanitize collect mntinfo error path · 90891588

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

90891588

mnt: Mark fini_mnt_ns as void arg · f818065e

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f818065e

mnt: Helper for getting mntns root path · 02f7c5c6

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

02f7c5c6

mnt: Mark create_mnt_roots as void arg · 169dada8

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

169dada8

mnt: Mark rst_collect_local_mntns as void · f4b7a6fe

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f4b7a6fe

mnt: Merge mnt nss dumping and collecting code · b08af3a9

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

b08af3a9

mnt: Move collect and list of pms out of ns dumping routine · 33b7ec50

Pavel Emelyanov authored Apr 22, 2014

This is a helper for the next patch.
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

33b7ec50

mnt: Mark dump_mnt_ns as static · 88eef43e

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

88eef43e

mnt: Check for ns being mnt before dumping · f60109f2

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f60109f2

mnt: Sanitize the code of reading mnt images routine · d49fd40e
Pavel Emelyanov authored Apr 22, 2014
```
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
d49fd40e

mnt: Remove unneeded argument from prepare_mnt_ns · 4ffa7969

Pavel Emelyanov authored Apr 22, 2014

Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

4ffa7969

mnt: Fix void argument for reading mnt images helper · bc312d32
Pavel Emelyanov authored Apr 22, 2014
```
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
bc312d32
mnt: Helper for adding new set of mountpoints into global list · dd43b3c5
Pavel Emelyanov authored Apr 22, 2014
```
Acked-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
dd43b3c5