Commits · 4a6ed33203edd4ab6f628d799277d0a9ad1fe9d4 · zhul / criu

28 Mar, 2013 2 commits

netlink: return errno from do_rtnl_req · 4a6ed332

Andrey Vagin authored Mar 27, 2013

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

4a6ed332

restorer: Print error code from sys_set_robust_list · 421ceffa

Cyrill Gorcunov authored Mar 28, 2013

Some syscalls return error code, so for easier debugging
instead of zapping it -- print it together with error
message.

And make error message more detailed as well.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

421ceffa

27 Mar, 2013 16 commits

lock: Show long option in log message about using one · 87d0d61e
Pavel Emelyanov authored Mar 27, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
87d0d61e
tty: More descriptive log message about --shell-job requirement · 25ef4199
Pavel Emelyanov authored Mar 27, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
25ef4199

mount: remove root with MS_PRIVATE before cleaning up mntns · f16d7c64

Andrew Vagin authored Mar 26, 2013

Otherwise we will clean up the root mntns too.
Signed-off-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f16d7c64

mount: remove root with MS_PRIVATE before pivot_root · 929a0f24

Andrew Vagin authored Mar 26, 2013

Otherwise if the root is mounted with MS_SHARED, pivot_root fails with EINVAL.
Signed-off-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

929a0f24

rst: Properly check si_code of sigchild · 000404ad

Pavel Emelyanov authored Mar 27, 2013

The CLD_XXX macros are not bit fields.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

000404ad

caps: Print error message on size mismatch · 78ced79e

Cyrill Gorcunov authored Mar 27, 2013

So when we fail print error thus a user would know
where exactly it failed.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
CC: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

78ced79e

inventory: Kill inventory.img file in case of failed dump · cbf0ba9f

Pavel Emelyanov authored Mar 27, 2013

This will result in more sane error in case restore is launched
on such semi-complete images.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

cbf0ba9f

msg: Make final dump/restore more descriptive · c03a4c58

Pavel Emelyanov authored Mar 27, 2013

Currently dump silently terminates and restore emits some
meaning-less messages in either case. Make these important
messages more informative.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

c03a4c58

zdtm: execute sigpending and sk-netlink only on linux-cr · c721df56

Andrey Vagin authored Mar 26, 2013

The functionality for dumping signals and netlink sockets are not merged
in the upstream kernel yet.
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

c721df56

sk-packet: fix error handling · 27d0bbe5

Andrey Vagin authored Mar 27, 2013

lookup_socket() returns pointer or NULL.
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

27d0bbe5

restore: Unify exit() return code · e902861c

Cyrill Gorcunov authored Mar 27, 2013

Some exit()'s are called with exit(-1), some
are with exit(1). Use exit(1) everywhere for
consistency.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

e902861c

pie: Bump .got table into .crblob section · 18db781a

Cyrill Gorcunov authored Mar 27, 2013

It's being noticed on arm platform the .got table
has been missed to include in .crblob section,
so fix it.
Reported-by: Chanho Park <chanho61.park@samsusng.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

18db781a

x86: Use pr_perror instead of plain perror · 0905bfa0
Pavel Emelyanov authored Mar 27, 2013
```
And add pid arg for more verbosity.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
0905bfa0
dump: Be more specific about inability to dump 32bit tasks on x86 · b5dfd452
Pavel Emelyanov authored Mar 27, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
b5dfd452

sk-unix: Don't zap error returned · f95d509d

Cyrill Gorcunov authored Mar 27, 2013

If error happened during queue read don't zap it.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f95d509d

pages: Accept pages images from versions v0.4 and below · 421d46f7

Pavel Emelyanov authored Mar 27, 2013

After reworkring the way pagemap is stored the backward compatibility
was not preserved for patches simplicity. Time to return it back.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

421d46f7

26 Mar, 2013 12 commits

seize: Warn if crtools tried to seize self · 18242f83

Pavel Emelyanov authored Mar 26, 2013

That's not allowed by kernel, but having explicit message is nice.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

18242f83

help: Sanitize special resources options · 21cf5d2e

Pavel Emelyanov authored Mar 26, 2013

* remove obsoleted --namespaces
* use macro for ext socket option name in help text
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

21cf5d2e

ptrace: Be more verbose on seize failure · b6fa2b31

Pavel Emelyanov authored Mar 26, 2013

The ptrace seize may fail for various reasons. E.g. -- no enough perms
to get the ptrace access to the tasks, or various selinux restrictions.

Print what exactly has happened when ptrace failed.
Reported-by: Kevin Wilson <wkevils@gmail.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

b6fa2b31

collect: Properly report tasks collecting error · 7571ff69

Pavel Emelyanov authored Mar 26, 2013

When we've failed to seize tasks we should report this error to the caller.
Reported-by: Kevin Wilson <wkevils@gmail.com>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

7571ff69

dump: Missing \n in pr_err message. · 118526cc
Pavel Emelyanov authored Mar 26, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
118526cc

netlink: Don't signify error code · ecbe4883

Cyrill Gorcunov authored Mar 26, 2013

The netlink layer reports negative error code so no need to
signify it.

[xemul: This is what we do for the rest of the nlk code.]
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

ecbe4883

unix: More verbose output on ext unix socket dumping. · 6b8c824f
Pavel Emelyanov authored Mar 26, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
6b8c824f
check: More verbose messages when sock diag infratructure is missing. · fd5bcbe7
Pavel Emelyanov authored Mar 26, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
fd5bcbe7
unix: Make more descriptive error logging for ext socket restore failure · f52d53c5
Pavel Emelyanov authored Mar 26, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
f52d53c5
dump: Use pr_err when reporting error about locks in use and no -l option · 21c663dc
Pavel Emelyanov authored Mar 26, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
21c663dc

mount: Add missing \n in cr_pivot_root message · a7325952

Cyrill Gorcunov authored Mar 26, 2013

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

a7325952

check: Return -1 on error · e14d39ab
Cyrill Gorcunov authored Mar 26, 2013
```
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
e14d39ab

25 Mar, 2013 10 commits

zdtm: add a test case for netlink sockets · 282aaf2c

Andrey Vagin authored Mar 25, 2013

* create two bound socket (for unicase and broadcase messages),
  a connected socket, an unbound and unconnected socket.
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

282aaf2c

sockets: restore netlink sockets · 04f8a1a5

Andrey Vagin authored Mar 25, 2013

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

04f8a1a5

sockets: dump netlink sockets · b9e6a27c

Andrey Vagin authored Mar 25, 2013

All info about bound sockets are got via socket diag interface.
All connected sockets are automatically bound.
For other sockets only protocol must be dumped, which is got
with help getsockopt.

A netlink sockets with pending data are not supported yet and
probably will not be supported in a near future.
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

b9e6a27c

sockets: use socket diag for collecting netlink sockets · b17c9f64
Andrey Vagin authored Mar 25, 2013
```
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
```
b17c9f64

crtools: add netlink_diag.h · 47b9c69f

Andrey Vagin authored Mar 25, 2013

This header is taken from kernel sources.
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

47b9c69f

crtools: add constants for a netlink image · dda97cf7

Andrey Vagin authored Mar 25, 2013

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

dda97cf7

crtools: add a function for showing netlink sockets · 1eb24a0a

Andrey Vagin authored Mar 25, 2013

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

1eb24a0a

protobuf: add image for netlink sockets · 149a5a5e

Andrey Vagin authored Mar 25, 2013

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

149a5a5e

arm: added architecture-specific implementation of __cr_restore_rt · 803cb95e

Alexander Kartashov authored Mar 25, 2013

Signed-off-by: Alexander Kartashov <alekskartashov@parallels.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

803cb95e

arm: added the descriptions of the syscalls pread64, rt_sigqueueinfo, signalfd4, rt_tgsigqueueinfo · f904bc11

Alexander Kartashov authored Mar 25, 2013

Signed-off-by: Alexander Kartashov <alekskartashov@parallels.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>

f904bc11