- 28 Feb, 2012 11 commits
-
-
Cyrill Gorcunov authored
Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Acked-by:
Pavel Emelyanov <xemul@parallels.com>
-
Cyrill Gorcunov authored
The function has nothing to do with "pop" operation, it rather "pull"s descriptor out of list. Name it so. Signed-off-by:
-
Cyrill Gorcunov authored
Having them in the header file will allow to share these structures with other callers. Moreover, this is a good practice to have definition(s) in header file until otherwise really needed. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Will be needed for file-ids handling. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Though we can use libc's syscall() wrapper I would prefer to have own implementation in case if we will need it in non-libc bindable code. Signed-off-by:
-
Kinsbursky Stanislav authored
1) Use macro for defining size mapped size. 2) Allow to allocate all space (including the last byte). Signed-off-by:
Stanislav Kinsbursky <skinsbursky@openvz.org> Acked-by:
-
Kinsbursky Stanislav authored
Current heap has 10 MB free space. It should be enough. Otherwise something broken by design.. Signed-off-by:
-
Kinsbursky Stanislav authored
Stack heap size is probably small for dumping unix sockest skb's (it's hard to discover, how big it could be; thus let's assume that 10MB is enough, otherwise give up and throw error). So let' replace this stack heap wil 10 MB anonimous private mapping. Signed-off-by:
-
- 27 Feb, 2012 1 commit
-
-
Kinsbursky Stanislav authored
Signed-off-by:
-
- 22 Feb, 2012 4 commits
-
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Socket address is being generated with this function, name it so. Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
Andrey Vagin <avagin@openvz.org> Acked-by:
-
Andrey Vagin authored
Signed-off-by:
-
- 21 Feb, 2012 2 commits
-
-
Kinsbursky Stanislav authored
1) Added few missed successfull status setup - this looks redundant though, but unified with other functions. 2) remove redundant argument in dump_pages_fini(). Signed-off-by:
-
Kinsbursky Stanislav authored
v2: it's toom risky to jump to address equal to line numbet (there could be valid executable code). So now jump is done to 0 address and %sp encodes line number (32 most significant bits) and error code (32 least significant bits). There is a race between log close by process being restoring and opened file desctriptors check in zdtm test suite - crtools can exit and compare file descriptors before detached restored process will perform all the rest tasks (including close of the log) and execute final system call: |--- dump/sleeping00/8578/dump.fd 2012-02-20 14:31:31.246096000 +0300 |+++ dump/sleeping00/8578/restore.fd 2012-02-20 14:31:31.418095999 +0300 |@@ -1,4 +1,5 @@ | | 0 -> /dev/null | 1 -> /dev/null |+1023 -> /root/crtools/test/dump/sleeping00/8578/restore.log | 2 -> /dev/null The solution is to close log in restorer before final command received. But this leads to another problem: we have to inform somehow about possible errors afterwards This is done by forced segmentation fault and looks like this (dmesg): pipe00[4678]: segfault at 0 ip 00007f4c8ab77d02 sp 000002ed00000001 error 4 Where %sp encodes line number (32 most significant bits) and error code (32 least significant bits). Signed-off-by:
-
- 20 Feb, 2012 11 commits
-
-
Pavel Emelyanov authored
Signed-off-by:
-
Kinsbursky Stanislav authored
It's already closed in restore_mapping, just an unapplied patch snippet from 389bd830Signed-off-by:
-
Kinsbursky Stanislav authored
Signed-off-by:
-
Cyrill Gorcunov authored
In case if time is modified in ls -l output we should not treat it as error, interrupting zdtm work -lrwx------ 1 root root 64 Feb 17 14:52 0 -> /dev/null -lrwx------ 1 root root 64 Feb 17 14:52 1 -> /dev/null -lrwx------ 1 root root 64 Feb 17 14:52 2 -> /dev/null +lrwx------ 1 root root 64 Feb 17 14:53 0 -> /dev/null +lrwx------ 1 root root 64 Feb 17 14:53 1 -> /dev/null +lrwx------ 1 root root 64 Feb 17 14:53 2 -> /dev/null Signed-off-by:
Andrew Vagin <avagin@parallels.com> Acked-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
They are redundant, and simply overlog the output Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
This is a place where they should belong to. util.c is too big already. Signed-off-by:
-
Cyrill Gorcunov authored
Don't forget to close opened file in case of error. Signed-off-by:
-
Cyrill Gorcunov authored
map_files format defined as %lx-%lx in kernel and while there should not be a problem if it's written in %p-%p, still better to be on a safe side and follow kernel's notation. Signed-off-by:
-
Pavel Emelyanov authored
The ptrace seize doesn't prevent signals from delivery. That said, we should block the signals in the target task before dumping anything which is signals-related, i.e. memory and registers. But once we've blocked signals, we should dump registers before unblocking them, since any postponed signal will screw things up. Signed-off-by:
-
- 17 Feb, 2012 11 commits
-
-
Kir Kolyshkin authored
This patch tries to introduce lazy and hidden pid_dir support, meaning one don't have to worry about pid_dir but the optimization is still there. The patch relies on the fact that we work with many /proc/pid files for one pid, then for another pid and so on, i.e. not in a random manner. The idea is when we call open_proc() with a new pid for the first time, the appropriate /proc/PID directory is opened and its fd is stored. Next call to open_proc() with the same PID only need to check that the PID is not changed. In case PID is changed, we close the old one and open/store a new one. Now the code using open_proc() and friends: - does not need to carry proc_pid around, pid is enough - does not need to call open_pid_proc() The only thing that can't be done in that "lazy" mode is closing the last PID fd, thus close_pid_proc(). Signed-off-by:
Kir Kolyshkin <kir@openvz.org> Acked-by:
-
Kir Kolyshkin authored
...and make it correctly print the file name we were unable to open. Also, error from fdopen[dir]() is now reported with file name as well. Note that open_proc() and friends need to be macros in order for pr_perror() to show actual file name and line number where error occured. Historical note: the original version of this patch was way more radical, changing openat() to open() and thus removing pid_dir (replacing with pid when needed) and open_proc_dir(), changing openat() to open(). The word from Pavel is he wants to keep the openat/pid_dir optimization because it saves two dentry lookups in kernel code for each open(). Because of this optimization (and desire to print correct file name in case of error) we have to carry both pid and pid_dir everywhere. Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
To be used by the next patch Signed-off-by:
-
Kinsbursky Stanislav authored
It's not a fd to open and map, but SYSV IPC id instead. So don't close it - this may lead to unpredictable results (in case of SYSV IPC id will match fd, opened by processes). Signed-off-by:
-
Kinsbursky Stanislav authored
This looks clearer, because this check has nothing with SYSV IPC mappings. Also we don't modify the vma_entry itself anymore but operate with local 'flags' copy. Signed-off-by:
-
Kinsbursky Stanislav authored
Signed-off-by:
-
Andrey Vagin authored
* Remove redundant messages * Show which test will be executed Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Kir Kolyshkin authored
Make sure we close it Signed-off-by:
-
Kir Kolyshkin authored
Otherwise 'make test' fails on a clean tree because crtools is not built. Side effect: if you have code modifications that are not yet compiled, they will be compiled. Signed-off-by:
-
