- 09 Apr, 2013 2 commits
-
-
Pavel Emelyanov authored
O_RSTR flag should be used instead for regular open_image Signed-off-by:Pavel Emelyanov <xemul@parallels.com>
-
Pavel Emelyanov authored
Will need vpid there soon, so switch to using ctl instead. Signed-off-by:
-
- 08 Apr, 2013 6 commits
-
-
Pavel Emelyanov authored
This saves some space on stack. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
We work on pid, not ctl->pid in that place. Signed-off-by: -
Pavel Emelyanov authored
There's going to be a LOT of code in there. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by:
-
- 05 Apr, 2013 10 commits
-
-
Cyrill Gorcunov authored
In case if openat/open call returned fd = 0, don't forget to close it on routine exit, ie just use close_safe macro. Not a big deal since the descriptors get closed once program finish execution but still. #CID 996183 Resource leak Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Andrey Vagin authored
It's opened in switch_ns. CID 996194 (#3 of 5): Resource leak (RESOURCE_LEAK) 11. leaked_handle: Handle variable rst going out of scope leaks the handle. Signed-off-by:
Andrey Vagin <avagin@openvz.org> Signed-off-by:
-
Andrey Vagin authored
CID 996197 (#1 of 1): Resource leak (RESOURCE_LEAK) 8. leaked_storage: Variable ppb going out of scope leaks the storage it points to. Signed-off-by:
-
Andrey Vagin authored
CID 996201 (#1 of 1): Resource leak (RESOURCE_LEAK) 9. leaked_handle: Handle variable "fd" going out of scope leaks the handle. CID 996202 (#1 of 1): Resource leak (RESOURCE_LEAK) 6. leaked_handle: Handle variable "fd" going out of scope leaks the handle. Signed-off-by:
-
Andrey Vagin authored
CID 996203 (#1 of 1): Resource leak (RESOURCE_LEAK) 15. leaked_storage: Variable "vma" going out of scope leaks the storage it points to. Signed-off-by:
-
Andrey Vagin authored
CID 996204 (#1 of 1): Resource leak (RESOURCE_LEAK) 11. leaked_storage: Variable "ch" going out of scope leaks the storage it points to. Signed-off-by:
-
Andrey Vagin authored
CID 996205 (#1-2 of 2): Resource leak (RESOURCE_LEAK) 14. leaked_storage: Variable "core" going out of scope leaks the storage it points to. Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
CID 996206 (#3 of 3): Resource leak (RESOURCE_LEAK) 8. leaked_handle: Handle variable "sk" going out of scope leaks the handle. Signed-off-by:
-
Andrey Vagin authored
CID 996207 (#1 of 1): Out-of-bounds access (OVERRUN) 5. alloc_strlen: Allocating insufficient memory for the terminating null of the string. Signed-off-by:
-
- 04 Apr, 2013 20 commits
-
-
Cyrill Gorcunov authored
simfs is used in OpenVZ containers, so lets understand it and don't fail on its meeting. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
No need to include all types here. And this allows to reuse this header outside of crtools code. Signed-off-by:
-
Alexander Kartashov authored
The macro PAGE_SIZE is declared in the following way in Debian: #define PAGE_SIZE (sysconf(_SC_PAGESIZE)) that makes it impossible to use the macro as the size of the array clone_args::stack since this generates the following error: cc -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -iquote ../../lib/arch/arm/include -I../../lib session02.c ../../lib/libzdtmtst.a -o session02 session02.c:70:7: error: variably modified 'stack' at file scope Cc: Andrey Vagin <avagin@openvz.org> Signed-off-by:
Alexander Kartashov <alekskartashov@parallels.com> Acked-by:
Andrew Vagin <avagin@parallels.com> Signed-off-by:
-
Alexander Kartashov authored
Use a PRI* format specifier to convert an integer of known size to a string. Cc: Andrey Vagin <avagin@openvz.org> Signed-off-by:
-
Andrey Vagin authored
pstree.c:273:3: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Signed-off-by: -
Andrey Vagin authored
files.c:159:21: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (p->fown.signum < 0) { ~~~~~~~~~~~~~~ ^ ~ Signed-off-by: -
Andrey Vagin authored
cr-restore.c:1795:2: warning: Value stored to 'restore_task_vma_len' is never read restore_task_vma_len = 0; ^ ~ cr-restore.c:1796:2: warning: Value stored to 'restore_thread_vma_len' is never read restore_thread_vma_len = 0; Signed-off-by: -
Andrey Vagin authored
ipc_ns.c:464:3: warning: Memory is never released; potential leak of memory pointed to by 'values' return; ^ 1 warning generated. Signed-off-by: -
Andrey Vagin authored
pie/parasite.c:308:3: warning: Value stored to 'ret' is never read ret = -1; Signed-off-by: -
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
clang requires that. In file included from arch/x86/cpu.c:9: arch/x86/include/asm/bitops.h:24:15: error: ambiguous instructions require an explicit suffix (could be 'btsw', 'btsl', or 'btsq') asm volatile("bts %1,%0" : ADDR : "Ir" (nr) : "memory"); Signed-off-by: -
Andrey Vagin authored
clang-analyzer sets the environment variable CC scan-build -plist-html --use-analyzer /usr/bin/clang make Signed-off-by:
-
Pavel Emelyanov authored
If any task has a sysvipc mapping we should make sure, that the ipc namespace is dumped as well. Otherwise after restore the task will die. Signed-off-by: -
Pavel Emelyanov authored
Absense of packet and netlink diag is OK at dump -- we can be on older kernel and will fail later if _really_ need these sockets. During check stage all diag is expected to be in place. Signed-off-by:
-
- 02 Apr, 2013 2 commits
-
-
Pavel Emelyanov authored
When dumping a unix socket we must make sure, that all connections are dumped or -x option is used. Currently only peers with non-matching ids are added into check. Fix this. Signed-off-by: -
Cyrill Gorcunov authored
To reuse them outside of crtools code. Signed-off-by:
-
