- 01 Feb, 2012 11 commits
-
-
https://github.com/avagin/crtoolsCyrill Gorcunov authored
* 'zdtm' of https://github.com/avagin/crtools: zdtm: set SA_RESTART everywhere zdtm.sh: clean up zdtm: print test dir, dump and restore path (if any) in case of error
-
Andrey Vagin authored
Signed-off-by:
Andrey Vagin <avagin@openvz.org> Acked-by:
Pavel Emelyanov <xemul@parallels.com> Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org>
-
Andrey Vagin authored
-
Andrey Vagin authored
-
Stanislav Kinsbursky authored
v7: cosmetic chages due to public pressure v6: silly "/" miss fixed v5: it finally workks as expected v4: fixed wrong error print after successfull run on all zdtm tests v3: spaces removed v2: print test output file path (if present) Print dump and restore file in case of running all tests suit. Signed-off-by:
Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by:
Andrey Vagin <avagin@gmail.com>
-
Cyrill Gorcunov authored
I've got it if -O2 compilation option used. | cr-restore.c:1069:5: error: ‘ret’ may be used uninitialized in this function [-Werror=uninitialized] | sockets.c:1145:7: error: ‘sk’ may be used uninitialized in this function [-Werror=uninitialized] In first case 'ret' indeed might be uninitialized, and in second case "goto err" was called too early. Fix them both. Signed-off-by: -
Cyrill Gorcunov authored
Signed-off-by: -
Cyrill Gorcunov authored
Signed-off-by: -
Cyrill Gorcunov authored
Signed-off-by: -
Cyrill Gorcunov authored
Reported-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
- 31 Jan, 2012 29 commits
-
-
Kir Kolyshkin authored
Use sizeof() instead. Signed-off-by:
Kir Kolyshkin <kir@openvz.org> Signed-off-by:
-
Kir Kolyshkin authored
We do not want to use pr_perror() here, because 1. fscanf only sets errno in case it returns EOF 2. we are not really interested in errno value So use pr_err() instead. Signed-off-by:
-
Kir Kolyshkin authored
* kid -> child * First letter should be uppercase * Misc typos in messages and comments Signed-off-by:
-
Kir Kolyshkin authored
There are quite a few cases where we need to print system error string. Signed-off-by:
-
Cyrill Gorcunov authored
- drop hardcoded numbers, use sizeof - drop unneeded local argument Signed-off-by: -
Cyrill Gorcunov authored
Signed-off-by: -
Cyrill Gorcunov authored
Signed-off-by: -
Cyrill Gorcunov authored
Which was missed to add to git index in one of previous IPC patch series. Signed-off-by: -
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
v2: strlen() check removed from parse_ns_string() Now '-n' option must be followed by namespaces tags, separated by commas. Currently, only "uts" namespace is supported. Signed-off-by:
-
Cyrill Gorcunov authored
It requires properly syncs in test case itself so I need to rewrite the test code (which I'm going to do pretty soon). Meanwhile drop this test-case. Signed-off-by:
-
Cyrill Gorcunov authored
There are two cases for cr_fdset_open - It might be called with already allocated memory so we should reuse it. - It might be called with NULL pointing out that caller expects us to allocate memory. If an open() error happens somewhere inside cr_fdset_open it requires two error paths - Just close all files opened but don't free memory if it was not allocated by us - Close all files opened *and* free memory allocated by us. In any case we should close all files opened so close_cr_fdset() helper is splitted into two parts. Also the caller should be ready for such semantics as well and do not re-assign pointers obtained but simply test for NULL on results. Signed-off-by:
-
Kir Kolyshkin authored
- Fix printing the same address on every line (ie p+i, not p). - Use GNU %p to print pointer, to avoid messing with width etc. Side effect: 0x is added, hope that's ok. Signed-off-by:
-
Cyrill Gorcunov authored
To eliminate format problem | util.c:60:10: error: format ‘%lx’ expects argument of | type ‘long unsigned int’, but argument 2 has type | ‘unsigned char *’ [-Werror=format] Signed-off-by: -
Kir Kolyshkin authored
files.c: In function ‘collect_fd’: files.c:111:2: error: format ‘%d’ expects type ‘int’, but argument 3 has type ‘u64’ files.c: In function ‘open_fd’: files.c:348:3: error: format ‘%d’ expects type ‘int’, but argument 2 has type ‘u64’ files.c: In function ‘receive_fd’: files.c:425:5: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘u64’ files.c:425:5: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘u64’ Signed-off-by:
-
Kir Kolyshkin authored
sockets.c: In function ‘try_dump_socket’: sockets.c:366:3: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘__ino_t’ Signed-off-by:
-
Kir Kolyshkin authored
cr-show.c: In function ‘show_pipes’: cr-show.c:119:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 2 has type ‘u32’ cr-show.c:119:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 3 has type ‘u32’ cr-show.c:119:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 4 has type ‘u32’ cr-show.c:119:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 5 has type ‘u32’ Signed-off-by:
-
Kir Kolyshkin authored
cr-dump.c: In function ‘dump_one_reg_file’: cr-dump.c:128:2: error: format ‘%8x’ expects type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ cr-dump.c: In function ‘dump_one_pipe’: cr-dump.c:223:2: error: format ‘%d’ expects type ‘int’, but argument 2 has type ‘long unsigned int’ cr-dump.c:237:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 2 has type ‘u32’ cr-dump.c:237:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 3 has type ‘u32’ cr-dump.c:237:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 4 has type ‘u32’ cr-dump.c:237:3: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 5 has type ‘u32’ cr-dump.c:240:3: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘long unsigned int’ cr-dump.c: In function ‘dump_one_fd’: cr-dump.c:257:3: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘long unsigned int’ cr-dump.c:262:3: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘long unsigned int’ cr-dump.c:272:4: error: format ‘%d’ expects type ‘int’, but argument 3 has type ‘long unsigned int’ cr-dump.c:286:4: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘long unsigned int’ cr-dump.c:295:2: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘long unsigned int’ cr-dump.c: In function ‘dump_task_files’: cr-dump.c:340:3: error: too few arguments for format Signed-off-by:
-
Kir Kolyshkin authored
proc_parse.c: In function ‘parse_maps’: proc_parse.c:75:6: error: format ‘%Lu’ expects type ‘long long unsigned int’, but argument 5 has type ‘u64’ proc_parse.c:118:5: error: format ‘%Lu’ expects type ‘long long unsigned int’, but argument 5 has type ‘u64’ Signed-off-by:
-
Kir Kolyshkin authored
cr-restore.c: In function ‘fixup_vma_fds’: cr-restore.c:578:4: error: format ‘%d’ expects type ‘int’, but argument 6 has type ‘long unsigned int’ cr-restore.c: In function ‘sigreturn_restore’: cr-restore.c:1693:4: error: format ‘%li’ expects type ‘long int’, but argument 4 has type ‘int’ cr-restore.c:1738:3: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘long int’ cr-restore.c:1751:3: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘long int’ cr-restore.c:1755:3: error: format ‘%d’ expects type ‘int’, but argument 3 has type ‘long int’ cr-restore.c:1868:4: error: format ‘%8p’ expects type ‘void *’, but argument 3 has type ‘long int’ Signed-off-by:
-
Kir Kolyshkin authored
This way gcc will be able to catch invalid format bugs. Signed-off-by:
-
Kir Kolyshkin authored
When trying to compile the beast with clang, it complains: ==== ./include/lock.h:33:2: error: indirection of non-volatile null pointer will be deleted, not trap BUG_ON(ret < 0); ^~~~~~~~~~~~~~~ In file included from restorer.c:18: ./include/util.h:118:27: note: instantiated from: #define BUG_ON(condition) BUG_ON_HANDLER((condition)) ^ ./include/util.h:100:4: note: instantiated from: *(unsigned long *)NULL = 0xdead0000 + __LINE__; \ ^ ==== Make clang happy again by adding 'volatile'. Signed-off-by: -
Kir Kolyshkin authored
This is a standard convention to print error message (i.e. strerror(errno)) at the end of line, like this: Cannot remove file: Permission denied So pr_perror is fixed to follow this convention (using GNU extension %m helps a lot here). Unfortunately, due to this we have to make pr_perror() print a new line character, too, so we had to strip it from the all pr_perror() invocations. That (appending a newline) also makes pr_perror() a black sheep in the herd of pr_* helpers, but what can we do? Worst case scenario is an extra newline after an error message, not too harmful. An alternative approach (stripping the newline from the passed format string and re-adding it) was discussed thoroughly, and it was decided that such a hack looks a bit too dirty. Signed-off-by: -
Stanislav Kinsbursky authored
Generic code will be used for other namespaces. Signed-off-by:
-
Kir Kolyshkin authored
Found using clang: cr-restore.c:796:8: error: use of unary operator that may be intended as compound assignment (+=) size =+ ret; ^~ Signed-off-by:
-
