- 23 Sep, 2015 3 commits
-
-
Andrew Vagin authored
*** CID 150397: Memory - illegal accesses (UNINIT) /lib/criu.c: 696 in criu_local_add_irmap_path() 690 691 return 0; 692 693 err: 694 if (my_path) 695 free(my_path); >>> >>> CID 150397: Memory - illegal accesses (UNINIT) >>> >>> Using uninitialized value "m". 696 if (m) 697 free(m); 698 699 return -ENOMEM; 700 } 701 Signed-off-by:
Andrew Vagin <avagin@openvz.org> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
Andrew Vagin authored
Signed-off-by:
-
Andrew Vagin authored
Reported-by:
Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by:
-
- 21 Sep, 2015 20 commits
-
-
Pavel Emelyanov authored
Actually make use of the ns->type field and remove all getpid()'s and other strange/inconsistent checks. Signed-off-by: -
Pavel Emelyanov authored
We (may) have 3 types of namespace objects in criu -- criu's one, root task's one and others. All of them sometimes make sense and we differentiate them in a weird way -- by checking the ns->pid field against getpid() or by comparing with root_item's. The proposal is to mark ns_id objects explicitly with type field. Signed-off-by: -
Pavel Emelyanov authored
We don't need the read tree earlier. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
When we don't do unlink no need to lookup for ns root-fd Signed-off-by: -
Tycho Andersen authored
We'll use this in the next patch to correctly write sysctls. Signed-off-by:
-
Tycho Andersen authored
We'll use this size in the next patch to avoid having to do some dynamic allocation. v2: call it MAX_UNSFD_MSG_SIZE instead v3: fix all uses of MAX_MSG_SIZE :) Signed-off-by:
-
Andrew Vagin authored
/proc/locks can contains the same locks twice, if someone releases a lock when we are reading this file. Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Currently we have only one common flag. It is MS_READONLY and it's interpreted as a super block flag to not change old behaviour. v2: add a comment Signed-off-by:
-
Andrey Vagin authored
They both can container the MS_READONLY flag. And in one case it will be read-only bind-mount and in another case it will be read-only super-block. v2: set mnt and sb for one call of mount() when it's posiable v3: return a comment which was deleted by mistake v4: Fix the sentense about restoring mnt flags Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Pavel Emelyanov authored
Currently there are open flags on reg-files and vma flags and prot. Signed-off-by: -
Pavel Emelyanov authored
Some flags have known text description, e.g. flags on a file or flags on vma. Add ability to show these flags in decoded form (and encode them back into binary). Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
This should print some information about image file itself, e.g. statistical information. Right now print magic and the number of object written in the file. Signed-off-by: -
Marcos Lilljedahl authored
"criu cpuinfo [dump | check]" can't be used through the command line as this validation kicks in. Other commands will fail due to required arguments so I believe it's not necessary anymore. Signed-off-by:
Marcos Lilljedahl <marcosnils@gmail.com> Signed-off-by:
-
Tycho Andersen authored
This option allows users to specify their own irmap paths to scan in the event that they don't have a path in one of the hard coded hints. Signed-off-by:
-
- 16 Sep, 2015 5 commits
-
-
Andrey Vagin authored
Some controllers can be disabled in kernel options. In this case they are shown in /proc/cgroups, but they could not be mounted. All enabled controllers can be collected from /proc/self/cgroup. https://github.com/xemul/criu/issues/28 v2: ',' is used to separate controllers Cc: Tycho Andersen <tycho.andersen@canonical.com> Reported-by:
Ross Boucher <boucher@gmail.com> Signed-off-by:
-
Cyrill Gorcunov authored
It's very convenient to grep the log for mount related operations only. Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Cyrill Gorcunov authored
Otherwise we hit nil dereference. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Andrew Vagin authored
In this case a time wait bucket will be created on a client side, where a port is allocated dinamically. Reported-by: Mr Jenkins Signed-off-by:
-
- 10 Sep, 2015 12 commits
-
-
Andrey Vagin authored
Reported-by: Mr. Travis Signed-off-by:
-
Laurent Dufour authored
This test, specific to the ppc64 architecture, is checking that the content of the VSX registers is correctly checkpointed and restored. Signed-off-by:
Laurent Dufour <ldufour@linux.vnet.ibm.com> Acked-by:
Andrew Vagin <avagin@odin.com> Signed-off-by:
-
Laurent Dufour authored
Signed-off-by:
-
Laurent Dufour authored
The following tests are failing when run on ppc64 and are designed for x86 architecture. Moving them to the x86's test list. Signed-off-by:
-
Laurent Dufour authored
The commit ba743509 which introduces support for Altivec and VSX support was breaking the checkpoint --leave-running. The root cause is that the address of the Altivec and VSX registers in the signal frame should be computed for the stack in the context of the checkpointed process. This patch fixes this issue through the sigreturn_prep_fpu_frame which is designed to update the signal frame based on the remote address. Fixes: ba743509 ("ppc64: Add Altivec and VSX support") Reported-by:
-
Andrew Vagin authored
If you call clone directly you are responsible for setting up the TLS area yourself. $ abrt-cli ls | grep different_creds | wc -l 39 $ gdb -c /var/spool/abrt/ccpp-2015-07-24-10\:21\:14-8014/coredump different_creds Core was generated by `./different_creds --pidfile=different_creds.pid --outfile=different_creds.out'. Program terminated with signal SIGILL, Illegal instruction. #0 0x00007f86e2d8c7d9 in _dl_x86_64_restore_sse () from /lib64/ld-linux-x86-64.so.2 Missing separate debuginfos, use: dnf debuginfo-install glibc-2.21-7.fc22.x86_64 libattr-2.4.47-9.fc22.x86_64 libcap-2.24-7.fc22.x86_64 (gdb) bt #0 0x00007f86e2d8c7d9 in _dl_x86_64_restore_sse () from /lib64/ld-linux-x86-64.so.2 #1 0x00007f86e2d84add in _dl_fixup () from /lib64/ld-linux-x86-64.so.2 #2 0x00007f86e2d8bbc0 in _dl_runtime_resolve () from /lib64/ld-linux-x86-64.so.2 #3 0x0000000000402da3 in sys_futex (val3=0, uaddr2=0x0, timeout=0x0, val=0, op=0, uaddr=0x6063f0 <sig_received>) at lock.h:29 #4 futex_wait_while (f=0x6063f0 <sig_received>, v=0) at lock.h:121 #5 test_waitsig () at test.c:367 #6 0x0000000000401c4b in main (argc=<optimized out>, argv=0x7ffce16432f8) at different_creds.c:82 Reported-by: Mr Jenkins Cc: Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by:
-
Laurent Dufour authored
There was a \n missing. CC: Pavel Emelyanov <xemul@parallels.com> Signed-off-by:
-
Laurent Dufour authored
There were multiple copy of the same code spread over the different architectures handling the vDSO. This patch is merging the duplicated code in arch/*/vdso-pie.c and arch/*/include/asm/vdso.h in the common files and let only the architecture specific part in the arch/*/* files. The file are now organized this way: include/asm-generic/vdso.h contains basic definition which could be overwritten by architectures. arch/*/include/asm/vdso.h contains per architecture definitions. It may includes include/asm-generic/vdso.h pie/util-vdso.c include/util-vdso.h These files contains code and definitions common to both criu and the parasite code. The file include/util-vdso.h includes arch/*/include/asm/vdso.h. pie/parsite-vdso.c include/parasite-vdso.h contains code and definition specific to the parasite code handling the vDSO. The file include/parasite-vdso.h includes include/util-vdso.h. arch/*/vdso-pie.c contains the architecture specific code installing the vDSO trampoline. vdso.c include/vdso.h contains code and definition specific to the criu code handling the vDSO. The file include/vdso.h includes include/util-vdso.h. CC: Christopher Covington <cov@codeaurora.org> CC: Pavel Emelyanov <xemul@parallels.com> Signed-off-by:
Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by:
-
Laurent Dufour authored
Merge arch/*/vdso.c files in vdso.c. The merge has been done by copying arch/x86/vdso.c in vdso.c since it contains patch a67e9f7b ("vdso: don't play with a function exit code"). The commit f9ae6d9d ("Replace remaining hard-coded TASK_SIZE use") pushed in the aarch64 has been replicated since it should be cross platform. CC: Christopher Covington <cov@codeaurora.org> CC: Pavel Emelyanov <xemul@parallels.com> Signed-off-by:
-
Laurent Dufour authored
When building without the vDSO support on PowerPC (which is not a good idea), the build is failing because few files are not included in the build. This fix moves those files inclusion outside of the vDSO directive. CC: Pavel Emelyanov <xemul@parallels.com> Signed-off-by:
-
Tycho Andersen authored
In ubuntu wily, these paths are inotify'd by various daemons, so we should watch them as well. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
