- 28 Oct, 2015 3 commits
-
-
Andrey Vagin authored
fail() saves all files in an archive for further investigations. Signed-off-by:
Andrey Vagin <avagin@openvz.org> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
On loaded jenkins nodes sometimes it takes much more than 4 seconds. Signed-off-by:
-
- 27 Oct, 2015 10 commits
-
-
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Kirill Tkhai authored
Add support for save and restore of ip rules. It uses new functionality of iproute which is already in iproute git: http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=2f4e171f7df22107b38fddcffa56c1ecb5e73359 v2: Use xstrdup() instead of strdup(). v3: Use open/close instead of helper. v4: Return -1 on empty dump. Signed-off-by:
Kirill Tkhai <ktkhai@odin.com> Signed-off-by:
-
Andrew Vagin authored
Signed-off-by:
-
Andrew Vagin authored
This values will be doubled in kernel to account for "struct sk_buff" etc. overhead. Currently criu restores snd and rcv buffer limits incorrectly, they become bigger on each iteration. $ ../crit show dump/zdtm/live/static/socket-tcp/6299/1/inetsk.img | grep buf "so_sndbuf": 2626560, "so_rcvbuf": 1060720, "so_sndbuf": 16384, "so_rcvbuf": 87380, $ ../crit show dump/zdtm/live/static/socket-tcp/6299/2/inetsk.img | grep buf "so_sndbuf": 5253120, "so_rcvbuf": 2121440, "so_sndbuf": 32768, "so_rcvbuf": 174760, $ ../crit show dump/zdtm/live/static/socket-tcp/6299/3/inetsk.img | grep buf "so_sndbuf": 10506240, "so_rcvbuf": 4242880, "so_sndbuf": 65536, "so_rcvbuf": 349520, With-help-of: Pavel Emelyanov <xemul@parallels.com> Signed-off-by: -
Pavel Emelyanov authored
Currently --iter N results in sequential images for every new iteration. Signed-off-by: -
Cyrill Gorcunov authored
When restoring venet device we need to restore its index as well, which actually possible with new iproute2 package but the problem is that the index itself lays inside image file. We could use crit tool to extract it but this would slowdon procedure signifantly (need to run python which would parse the image, or need to pass the index into environmnet from inside of the CRIU itself). So lets do a trick and simply created venet device inside container by criu itself (thanks we support creating venet via netlink interface now). Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Acked-by:
Andrew Vagin <avagin@odin.com> Signed-off-by:
-
Pavel Emelyanov authored
Current implementation of print_sep has off-by-one-like issue -- it can print one character more :) Fix this and make the code shorter. Signed-off-by: -
Andrew Vagin authored
Currently we read only 4096 bytes (the size of buf). v2: use the bfd engine Signed-off-by:
-
Andrew Vagin authored
Reading stops after an EOF or a specified charecter. Signed-off-by:
-
- 26 Oct, 2015 15 commits
-
-
Andrew Vagin authored
There is no permissions to set sysctl-s v2: add the suid flag Signed-off-by:
-
Andrew Vagin authored
We don't have enough permissions to set sysctl-s from userns, while system calls are ns_capable()-protected in the kernel and thus work in user-namespaces. Signed-off-by:
-
Pavel Emelyanov authored
Signed-off-by: -
Andrew Vagin authored
Signed-off-by:
-
Andrew Vagin authored
Signed-off-by:
-
Andrew Vagin authored
5468 semctl(0, 1, IPC_SET, 0x7ffd25bcb590) = -1 EINVAL (Invalid argument) Reported-by:
-
Cyrill Gorcunov authored
Name with up to UNIX_PATH_MAX in length is allowed value. Reported-by:
Nikita Spiridonov <nspiridonov@odin.com> Signed-off-by:
-
Cyrill Gorcunov authored
Every print_on_level() injects timestamp, better to print it in one pass for readability. Signed-off-by:
-
Kir Kolyshkin authored
Sometimes pr_perror() is used in places that don't have errno set. In such places, pr_perror() should not be used as it will print some nonsense. Introduce and use pr_err() for such cases. Now, I see sometimes fail() is used in such cases but I think it is reserved for places where test fails (rather than there is something that prevents the test from working). Also, sometimes test_msg() is used but it doesn't print source file name and line number. If there will be a need, we can unify pr_err() with say fail(), it will be easier to do after this patch. Signed-off-by:
Kir Kolyshkin <kir@openvz.org> Acked-by:
Andrew Vagin <avagin@gmail.com> Signed-off-by:
-
Kir Kolyshkin authored
In this place, errno is not being set and can be 0 or some random value, so we should not use it. In case errno happens to be 0, we end up returning a success status from a function while we should have returned a failure. Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
Log function pr_perror() automatically adds - numeric errno value - string errno value (aka strerror(errno), aka %m) - a newline So, its callers don't have to do all these things. While at it, also - fix or improve some message texts - replace fnprintf() with pr_perror() Signed-off-by:
-
Kir Kolyshkin authored
In (highly unlikely) case localtime() failed, test_msg() calls pr_perror() which is a wrapper around test_msg() so we're calling ourselves, which can lead to infinite recursion if localtime() keeps failing. Use fprintf() here to avoid this. Signed-off-by:
-
Andrew Vagin authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
- 21 Oct, 2015 9 commits
-
-
Kir Kolyshkin authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
We gonna need it for inotify handle testing. Signed-off-by:
-
Andrew Vagin authored
Reported-by:
Andrew Vagin <avagin@virtuozzo.com> Acked-by:
-
Kir Kolyshkin authored
Contrary to a popular opinion, there is no need to check an argument for being non-NULL before calling free(). >From free(3) man page: > > If ptr is NULL, no operation is performed. Let's change xfree macro to be a synonym for free(). Signed-off-by:
-
Cyrill Gorcunov authored
In debian-8 container we faced the problem -- systemd creates nested mount namespaces and inotify watchee are resolved into a path which is inaccessbile on restore, the same happens when pathes where watchees are living are bind-overmounted. Thus when we try to restore such watchees we can't open the paths. Lets do a trick here (thanks a huge to Andrew Vagin for idea and overall help) -- walk over all mount points which device match the handle's device and open handle first and test if the path provided is openable as well for tmpfs and devtmps which do not save inodes between remounts. After all the inotify objects are bound to inode so it's irrelevean via which path it's assigned. https://jira.sw.ru/browse/PSBM-39957Signed-off-by:
-
Andrew Vagin authored
There is an another err() in glibc Signed-off-by:
-
Andrew Vagin authored
err() adds %m and \n at the end Signed-off-by:
-
Andrew Vagin authored
Signed-off-by:
-
- 20 Oct, 2015 3 commits
-
-
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by:
-
