- 24 Mar, 2015 3 commits
-
-
Andrey Vagin authored
* redirect both stdout and stderr bash: >& and &> dash: command > file 2>&1 or command 2>&1 | othercommand Signed-off-by:
Andrey Vagin <avagin@openvz.org> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
Andrey Vagin authored
mawk doesn't handle '\<...\>' Ubuntu: $ awk -W version mawk 1.3.3 Nov 1996, Copyright (C) Michael D. Brennan $ ldd /bin/ps linux-vdso.so.1 => (0x00007fffb290a000) $ ldd /bin/ps | awk '/\<linux-vdso\.so\>/ { print $1 }' $ ldd /bin/ps | awk '/linux-vdso\.so/ { print $1 }' linux-vdso.so.1 Fedora: $ ldd /bin/ps linux-vdso.so.1 => (0x00007fff61fcb000) $ ldd /bin/ps | awk '/\<linux-vdso\.so\>/ { print $1 }' linux-vdso.so.1 $ awk --version GNU Awk 4.1.1, API: 1.1 Signed-off-by: -
Andrey Vagin authored
Vladimir said that a page can be unmapped from one process, but can be mmaped in another one. In this case we can't understand whether both processes link to the same page or they don't. So we can try read both pages to take them from swap. Cc: Vladimir Davydov <vdavydov@parallels.com> Reported-by: Parallels' QA Signed-off-by:
-
- 23 Mar, 2015 1 commit
-
-
Andrey Vagin authored
cow01 uses /proc/pid/pagemap which has been protected by CAP_SYS_ADMIN. """ commit ab676b7d6fbf4b294bf198fb27ade5b0e865c7ce pagemap: do not leak physical addresses to non-privileged userspace As pointed by recent post[1] on exploiting DRAM physical imperfection, /proc/PID/pagemap exposes sensitive information which can be used to do attacks. """ Signed-off-by:
-
- 20 Mar, 2015 2 commits
-
-
Oleg Nesterov authored
Before the recent "x86_64,signal: Fix SS handling for signals delivered to 64-bit programs" kernel patch, sigreturn paths forgot to restore ->ss after return from the signal handler. Now that the kernel was fixed, restore_gpregs() has to initialize ->ss too, it is no longer ignored. Note: this is the minimal fix. In the long term we probably should not dump/restore the segment registers at all. We can use sigcontext filled by the target kernel and modify the general-purpose regs. Reported-and-tested-by:
Andrey Wagin <avagin@gmail.com> Signed-off-by:
Oleg Nesterov <oleg@redhat.com> Acked-by:
Cyrill Gorcunov <gorcunov@openvz.org> Acked-by:
-
Ruslan Kuprieiev authored
This is common for log files, when a number of processes are writing something into one file. Currently, if someone wrote something to log since dump happened, on restore criu will complain about "File has bad size" and refuse to restore. If file is opened with O_APPEND|O_WRONLY flags it is going to jump to the EOF anyway. v2, use O_ACCMODE and separate helper Signed-off-by:
Ruslan Kuprieiev <rkuprieiev@cloudlinux.com> Signed-off-by:
-
- 19 Mar, 2015 1 commit
-
-
Pavel Emelyanov authored
It's obsoleted and is not required. Signed-off-by:
-
- 18 Mar, 2015 2 commits
-
-
Kirill Tkhai authored
Print all cap values in case of test is failed. Also check for capset() and capsget() return values. Signed-off-by:
Kirill Tkhai <ktkhai@parallels.com> Signed-off-by:
-
Saied Kazemi authored
If the --restore-detached command line option is not specified during restore, CRIU should unmount and remove the temporary cgyard directory tree before waiting for the restored process to exit. Otherwise, all the temporary cgyard mount points will remain mounted and visible. Signed-off-by:
Saied Kazemi <saied@google.com> Signed-off-by:
-
- 16 Mar, 2015 3 commits
-
-
Andrey Vagin authored
Lazy images are opened on a first attempt of using. 00:01:18.534 Test: zdtm/live/static/pipe00, Result: FAIL 00:01:18.537 ==================================== ERROR ==================================== 00:01:18.538 Test: zdtm/live/static/pipe00, Namespace: 1 00:01:18.538 Dump log : /var/lib/jenkins/jobs/CRIU/workspace/test/dump/ns/static/pipe00/13536/1/dump.log 00:01:18.540 --------------------------------- grep Error --------------------------------- 00:01:18.543 (00.026666) Error (include/image.h:153): BUG at include/image.h:153 00:01:18.543 (00.050663) Error (namespaces.c:801): Namespaces dumping finished with error 134 00:01:18.543 (00.050918) Error (cr-dump.c:1979): Dumping FAILED. 00:01:18.545 ------------------------------------- END ------------------------------------- 00:01:18.548 ================================= ERROR OVER ================================= Reported-by: Mr Jenkins Signed-off-by:
-
Pavel Emelyanov authored
Currently on dump we generate too many image files, effectively all the stuff from the GLOB set is created. The thing is that sometimes some of created images can be empty (just contain the magic number at the head). Thos images are useless and just waste the space. When applied after the "empty images" set, this introduces the lazy images -- when we call open_image() the actual file is only created (and the magic number is written into it) when the very first object goes into it. For example for the simplest test we have, then static/env00 one, the created image files are core-7290.img creds-7290.img fdinfo-2.img fs-7290.img ids-7290.img inventory.img mm-7290.img pagemap-7290.img pages-1.img pstree.img reg-files.img sigacts-7290.img Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by:
-
- 13 Mar, 2015 4 commits
-
-
Pavel Emelyanov authored
When an image of a certian type is not found, CRIU sometimes fails, sometimes ignores this fact. I propose to ignore this fact always and treat absent images and those containing no objects inside (i.e. -- empty). If the latter code flow will _need_ objects, then criu will fail later. Why object will be explicitly required? For example, due to restoring code reading the image with pb_read_one, w/o the _eof suffix thus required the object to be in the image. Another example is objects dependencies. E.g. fdinfo objects require various files objects. So missing image files will result in non-resolved searches later. Signed-off-by: -
Pavel Emelyanov authored
When page-read fails to open the pagemap image it reports error. One place (stacked page-reads) need to handle the absent images case gracefully, so fix the return codes to make this check work. Signed-off-by: -
Pavel Emelyanov authored
Current code doesn't make any difference between OPT and no-OPT except for the message is printed or not in the open_image(). So this particular change changes nothing but the availability of this message. In the next patches I wil introduce "empty images" to deal with the ENOENT situation in a more graceful manner. Signed-off-by: -
Cyrill Gorcunov authored
Signed-off-by:
-
- 10 Mar, 2015 4 commits
-
-
Cyrill Gorcunov authored
As done for other structures here in file. Signed-off-by:
-
Cyrill Gorcunov authored
There are too many "type" in code. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
- 09 Mar, 2015 4 commits
-
-
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by:
-
- 04 Mar, 2015 15 commits
-
-
Pavel Emelyanov authored
Instead of open flags and boolean is_shmem argument. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Cyrill Gorcunov authored
- easier to read @posix_timers - more verbose logging is convernient for handling errors Signed-off-by:
-
Cyrill Gorcunov authored
Force-read came from very first dev version of CRIU (even before 1.0 release) and never been used actually in image. Signed-off-by:
-
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
And start making and using the TTY_PAIR one. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
This one is used on restore (and for static indices the constant value is used too). Signed-off-by: -
Pavel Emelyanov authored
This one gets index from fd/fd_parms pair on dump. For console and vt the index is constant and just sits on the tty_type (will also be used on restore, see next patch). Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
The plan is to replace tons of if (type == TTY_TYPE_FOO) checks with type->something dereferences. To do this, start with replacing int type with struct tty_type * in relevant places and fixing compilation. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by:
-
- 02 Mar, 2015 1 commit
-
-
Pavel Emelyanov authored
Here it is. The major new thing I think is the CRIT tool that will be the main one to mainupulate images and will eventually replace the "criu show" action. Signed-off-by:
-
