- 20 Jan, 2014 2 commits
-
-
Cyrill Gorcunov authored
It's ugly but should work for now. Strictly speaking I need to rework the complete make engine used in zdtm. Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Tested-by:
Andrew Vagin <avagin@parallels.com> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
Andrey Vagin authored
It's required for dumping fpu state [root@avagin-fc19-cr crtools]# bash test/zdtm.sh -d -P -i 2 static/fpu00 Execute zdtm/live/static/fpu00 ./fpu00 --pidfile=fpu00.pid --outfile=fpu00.out Dump 8411 Dump 8411 Check results 8411 01:29:30.550: 8411: FAIL: fpu00.c:78: 0.806165 != -nan (errno = 11 (Resource temporarily unavailable)) Signed-off-by:
Andrey Vagin <avagin@openvz.org> Acked-by:
-
- 16 Jan, 2014 5 commits
-
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
- drop '\' and ';' after the while(0) - drop empty line - use sizeof(*ptr) Signed-off-by:
-
Cyrill Gorcunov authored
Otherwise it's almost unreadable mess. Signed-off-by:
-
Andrey Vagin authored
./test/zdtm.sh -i 2 -P ns/static/env00 v2: make the help message a bit more detailed Signed-off-by:
-
Pavel Emelyanov authored
We have a big mistake in how we track for ptes to be SOFT_DIRTY -- no need in these checks if the --track-mem is not given. While fixing this, remember proper checks for the kernel memory tracker. Acked-by:
Tim Schürmann <info@tim-schuermann.de> Signed-off-by:
-
- 15 Jan, 2014 1 commit
-
-
Andrey Vagin authored
I don't why it is required here, but make doesn't work w/o it make[2]: Leaving directory `<https://10.30.26.89/job/CRIU/ws/test/zdtm/live/static'> make[1]: Leaving directory `<https://10.30.26.89/job/CRIU/ws/test/zdtm/live'> set -e; for d in lib live; do make -C $d default; done make[1]: Entering directory `<https://10.30.26.89/job/CRIU/ws/test/zdtm/lib'> make[1]: *** No rule to make target `default'. Stop. make[1]: Leaving directory `<https://10.30.26.89/job/CRIU/ws/test/zdtm/lib'> make: *** [default] Error 2 Signed-off-by:
Kir Kolyshkin <kir@openvz.org> Signed-off-by:
-
- 14 Jan, 2014 3 commits
-
-
Andrew Vagin authored
These files doesn't have own rules Signed-off-by:
-
Pavel Emelyanov authored
While doing pre-dump we don't do proper VDSO fixups, thus at this stage we may fail the should_dump_page() checks -- it will tread VDSO pages are 'regular' and may skip dumping some of them. This is not bad as is, but the subsequent dump will properly spot VDSO are and will try to dump _all_ pages from it. And if checks for soft-dirty will report that some pages are clean, dump will try to locate those in parent images and would fail. Acked-by:
-
Pavel Emelyanov authored
Signed-off-by:
-
- 13 Jan, 2014 1 commit
-
-
Pavel Emelyanov authored
If we're doing the pre-dump command we don't have the tasks' IDs collected, so we have the current_ns_mask uninitilized. Thus we create parasite transport socket in criu's namespace always and pre-dump of task, sitting in foreing net namespace may hang. From the "performance" point of view, it's easier to always create transport socket in victim's namespace, rahter than getting the current_ns_mask. Signed-off-by:
-
- 11 Jan, 2014 20 commits
-
-
Kir Kolyshkin authored
Broken by my commit 1fa0c0c0. I swear I was not drunk. Signed-off-by:
-
Pavel Emelyanov authored
There is no way in options to make page server send data to another page server -- the address/port ones would apply to local page server. Thus there is no need to open generic xfer in page server, just go to local one and avoid confusion Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by:
-
Kir Kolyshkin authored
While timestamps can be handy, they clutter output for normal users. Let's print them only when verbosity (-v) is increased from default. Currently, default is 2 (-vv) so for timestamps one should use -vvv or -v3. Alternatively, we could introduce a separate --timestamps option. Personally, I find it more handy for timestamps to be tied to log level. Signed-off-by:
-
Kir Kolyshkin authored
This is a slight refactoring of commit 7de96526, which just simplifies initialization of 'off' variable, and adds the comment why we do so. Should make the next patch easier to read. Cc: Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Kir Kolyshkin authored
Current description of -v[vvv] was taken from criu-log.h comments and describes specific log levels used by pr_* functions. The problem is -vX includes all previous X-1, X-2... levels. Say, -vvvv description says "debug only", while in fact it is not "only". Fix accordingly. Also, removed -v0 description as it is useless. What -v0 in fact does is it sets the log level to default -- same as if -vXXX is not used. In addition, change a delimiter between option alternatives from comma to a vertical bar in criu --help output, to be in line with the rest of usage output. Signed-off-by:
-
Kir Kolyshkin authored
This is just s/and/end/ to slightly improve readability. Signed-off-by:
-
Kir Kolyshkin authored
It can be handful to check how a man page looks in PDF or Postscript. Use 'make ps' and 'make pdf' to generate one. Signed-off-by:
-
Kir Kolyshkin authored
Only remove the files which we explicitly generate. Signed-off-by:
-
Kir Kolyshkin authored
* Don't show long usage in case of usage error, otherwise an actual error message will be lost in long output. * Print error if command is not specified. * Return 0 if criu --help is used. Signed-off-by:
-
Kir Kolyshkin authored
* Make "invalid usage" type messages uniform * Use pr_msg() not pr_err(), as we don't want to clutter output with useless information like (crtools.c:123). Signed-off-by:
-
Kir Kolyshkin authored
* Introduce a generic way to report that option argument is invalid * Switch to using it from existing places (options --veth-pair, --port, -n) * Check for invalid argument of -p and -t and report it. Notes: 1) In order to correctly print long option name in case it was used instead of a short one, I had to move "struct option long_opts" to main() context, this is why the patch is so long. 2) pr_msg() (rather than pr_err()) is used to print errors, otherwise it is prefixed with that (crtools.c:123) prefix which makes it look weird. 3) Usage is not shown in case of error, otherwise an error message is lost in output. Signed-off-by:
-
Kir Kolyshkin authored
In case open_image_dir() fails, it prints an error why, so there is no need to print it one more time. Signed-off-by:
-
Kir Kolyshkin authored
Use true instead of echo >/dev/null -- same effect, less bytes. Signed-off-by:
-
Kir Kolyshkin authored
When running 'make clean' from the top dir, the following error happens: make[3]: Leaving directory `/vz/kir/git/criu/test/zdtm/live/static' make[2]: Leaving directory `/vz/kir/git/criu/test/zdtm/live' set -e; for d in lib live; do make -C $d cleanout; done make[2]: Entering directory `/vz/kir/git/criu/test/zdtm/lib' make[2]: *** No rule to make target `cleanout'. Stop. make[2]: Leaving directory `/vz/kir/git/criu/test/zdtm/lib' make[1]: *** [cleanout] Error 2 make[1]: Leaving directory `/vz/kir/git/criu/test/zdtm' make: *** [clean] Error 2 Fix by adding dummy cleanout target to test/zdtm/lib/Makefile Signed-off-by:
-
Kir Kolyshkin authored
Forgot these ones Signed-off-by:
-
Kir Kolyshkin authored
...where they are missing. Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
- 05 Jan, 2014 1 commit
-
-
Pavel Emelyanov authored
The ret is overwritten by core read sub-routine. Need to reset it to -1 to keep failing in case of e.g. last pid sysctl write. Reported-by:
Neal Becker <ndbecker2@gmail.com> Signed-off-by:
-
- 04 Jan, 2014 2 commits
-
-
Pavel Emelyanov authored
When RPC is being requested to check the kernel, it's enough to check the minimal amount of kernel feature. Signed-off-by: -
Pavel Emelyanov authored
We might need to resolve socket paths, which will require mount infos tree collected. Reported-by:
-
- 31 Dec, 2013 2 commits
-
-
Pavel Emelyanov authored
Two major changes so far -- libcriu.so (RPC wrapper) and plugins. Both define some API and we want to check this API is good enough. Thus we tag the -rc1 to let people try it. If things go smooth, we will just go agead and tar the 1.1. Signed-off-by: -
Andrey Vagin authored
[root@avagin-fc19-cr ext]# bash run.sh + make make: Nothing to be done for `all'. + criu=../../../criu + finf=finish + outf=run_output + pidfile=pid_wait + tempd=temp_dir + sfile=source_file + tdir=test_dir + dfile=dest_file + mesg=msg-35 + export finf + export outf + export pidfile + export sfile + export dfile + export tempd + export mesg + export tdir + mkdir dump/ mkdir: cannot create directory ‘dump/’: File exists + mkdir test_dir mkdir: cannot create directory ‘test_dir’: File exists + mount --bind / test_dir + mount --make-rprivate test_dir + unshare --mount ./run_ns.sh + set -e + odir=mexold ++ pwd + cur=/root/crtools/test/mounts/ext + mount --make-rprivate / + rm -rf temp_dir finish run_output /mexold + mkdir temp_dir + touch test_dir/dest_file + mount -t tmpfs none temp_dir + echo msg-35 + mount --bind temp_dir/source_file test_dir//root/crtools/test/mounts/ext/test_dir/dest_file mount: mount point test_dir//root/crtools/test/mounts/ext/test_dir/dest_file does not exist + fail 'Can'\''t unshare ns' + echo 'Can'\''t' unshare ns Can't unshare ns + exit 1 Signed-off-by:
-
- 30 Dec, 2013 3 commits
-
-
Andrey Vagin authored
Makefile is locked, because tests can be executed concurrently. v2: return non-zero code Signed-off-by:
-
Andrey Vagin authored
make ZDTM_ARGS="-C -i 2" -C test/ zdtm_ns -j 8 make is able to execute tests concurrently. Now we can customize execution of tests Signed-off-by:
-
Andrey Vagin authored
If a mount is slave and it has a shared group. crtools must convert it in slave and only than crtools can make it shared. Signed-off-by:
-
