• Pavel Tikhomirov's avatar
    mount: fix parent shared group dependency in can_mount_now · 2214568d
    Pavel Tikhomirov authored
    What we do before patch:
    
    1) If we are NOT in the same shared group - if we have some parent's
    shared group member unmounted, we just wait for it.
    2) If we are in the same group - we wait only for members with root
    path len shorter than ours.
    
    That is done to make child mount propagate in all shared group,
    but I think it is wrong, e.g.:
    
    mkdir -p /dir/a/b/c /d /e /f
    mount --bind /dir/a /d
    mount --bind /dir/a/b /e
    mount --bind /f /e/c
    
    Before c/r we have:
    
    507 114 182:1017985 / / rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    144 507 182:1017985 /dir/a /d rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    146 507 182:1017985 /dir/a/b /e rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    148 146 182:1017985 /f /e/c rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    150 507 182:1017985 /f /dir/a/b/c rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    149 144 182:1017985 /f /d/b/c rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    
    After c/r we have:
    
    600 132 182:1017985 / / rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    602 600 182:1017985 /f /dir/a/b/c rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    603 600 182:1017985 /dir/a /d rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    604 600 182:1017985 /dir/a/b /e rw,relatime shared:63 master:60 - ext4 /dev/ploop63624p1 rw,data=ordered,balloon_ino=12
    
    There is no propagation as all mounts are in same shared group and
    602(150) has shorter root than 603(144) and 604(146).
    
    What we should do:
    
    Wait member of our parent's shared group only if it has our 'sibling'
    mount in it. Sibling mount is the one which had propagated to shared
    mount of our parent for us when we were mounted. We need to enforce
    propagation only for these case.
    
    https://jira.sw.ru/browse/PSBM-69501Signed-off-by: 's avatarPavel Tikhomirov <ptikhomirov@virtuozzo.com>
    Signed-off-by: 's avatarAndrei Vagin <avagin@virtuozzo.com>
    2214568d
Name
Last commit
Last update
Documentation Loading commit data...
compel Loading commit data...
contrib Loading commit data...
coredump Loading commit data...
crit Loading commit data...
criu Loading commit data...
images Loading commit data...
include/common Loading commit data...
lib Loading commit data...
scripts Loading commit data...
soccr Loading commit data...
test Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
INSTALL.md Loading commit data...
Makefile Loading commit data...
Makefile.compel Loading commit data...
Makefile.config Loading commit data...
Makefile.install Loading commit data...
Makefile.versions Loading commit data...
README.md Loading commit data...