• Kir Kolyshkin's avatar
    nmk/script: rm bad code · 25a1acd8
    Kir Kolyshkin authored
    I discovered that the scripts/ suffix is added to __nmk_dir despite
    the fact it already contains it, ending in obviously wrong filenames
    like scripts/nmk/scripts/scripts/msg.mk. As those files are non-existent,
    make tried to recreate every .mk file, spawninga child to execute 'true'
    command, like this (part of "make -dr" output):
    
    > Considering target file '../scripts/nmk/scripts/scripts/include.mk'.
    >  File '../scripts/nmk/scripts/scripts/include.mk' does not exist.
    >  Finished prerequisites of target file
    > '../scripts/nmk/scripts/scripts/include.mk'.
    > Must remake target '../scripts/nmk/scripts/scripts/include.mk'.
    > Putting child 0x564ec1768740 (../scripts/nmk/scripts/scripts/include.mk)
    > PID 21633 on the chain.
    > Live child 0x564ec1768740 (../scripts/nmk/scripts/scripts/include.mk)
    > PID 21633
    > Reaping winning child 0x564ec1768740 PID 21633
    > Removing child 0x564ec1768740 PID 21633 from chain.
    
    The fix was to remove the extra scripts/, but once I did it, I found
    out problem #2: these targets, being defined in contents that is often
    included in the beginning of Makefiles, hijacks the default make
    target (the first one in the Makefile), breaking the usual and
    expected make behavior, and forcing to use .DEFAULT_GOAL.
    
    Finally, I don't know why these targets are there, i.e. what purpose
    do they serve. Maybe it was done to exclude any implicit rules to
    re-make those files, but there are no such rules as far as I can see.
    
    So, in order to address problem #2, I have removed these targets.
    I don't see any harm in doing that; let me know if it breaks anything.
    
    Cc: Cyrill Gorcunov <gorcunov@openvz.org>
    Signed-off-by: 's avatarKir Kolyshkin <kir@openvz.org>
    Signed-off-by: 's avatarPavel Emelyanov <xemul@virtuozzo.com>
    25a1acd8
Name
Last commit
Last update
Documentation Loading commit data...
contrib Loading commit data...
coredump Loading commit data...
crit Loading commit data...
criu Loading commit data...
images Loading commit data...
lib Loading commit data...
scripts Loading commit data...
test Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
INSTALL.md Loading commit data...
Makefile Loading commit data...
Makefile.install Loading commit data...
Makefile.versions Loading commit data...
README.md Loading commit data...