• Tycho Andersen's avatar
    mnt: always_fail should report an error · b6a355c3
    Tycho Andersen authored
    Otherwise, you just see an anonymous failure in the logs, like:
    
    (00.244773) mnt: Dumping mountpoints
    (00.244781) mnt:        253: 42:/ @ ./dev/.lxc
    (00.244793) mnt: Path `/dev/.lxc' resolved to `./dev/.lxc' mountpoint
    (00.249039) mnt:        133: 41:/ @ ./dev/hugepages
    (00.249052) mnt:        116: 40:/ @ ./run/lock
    (00.249064) mnt: Path `/run/lock' resolved to `./run/lock' mountpoint
    (00.251948) mnt:        115: 3f:/ @ ./run
    (00.251970) mnt: Something is mounted on top of ./run
    (00.264803) mnt: Path `/run' resolved to `./run' mountpoint
    tar: ./uuidd/request: socket ignored
    tar: ./dbus/system_bus_socket: socket ignored
    tar: ./acpid.socket: socket ignored
    tar: ./systemd/journal/syslog: socket ignored
    tar: ./systemd/journal/dev-log: socket ignored
    tar: ./systemd/journal/socket: socket ignored
    tar: ./systemd/journal/stdout: socket ignored
    tar: ./systemd/private: socket ignored
    tar: ./systemd/notify: socket ignored
    (00.368950) mnt:        113: 3e:/ @ ./dev/shm
    (00.368978) mnt: Path `/dev/shm' resolved to `./dev/shm' mountpoint
    (00.371551) mnt:        112: 3d:/ @ ./dev/pts
    (00.371566) mnt:        249: 28:/ @ ./var/lib/lxcfs
    (00.371749) Unlock network
    (00.371762) Running network-unlock scripts
    (00.371766) Unfreezing tasks into 1
    (00.371770)     Unseizing 13683 into 1
    (00.371784)     Unseizing 14839 into 1
    (00.371794)     Unseizing 15678 into 1
    (00.371800)     Unseizing 16126 into 1
    (00.371805)     Unseizing 16177 into 1
    (00.371814)     Unseizing 16301 into 1
    (00.371843)     Unseizing 16323 into 1
    (00.371854)     Unseizing 16414 into 1
    (00.371900)     Unseizing 16595 into 1
    (00.371911)     Unseizing 16695 into 1
    (00.371942)     Unseizing 16744 into 1
    (00.371964)     Unseizing 16904 into 1
    (00.372103)     Unseizing 16944 into 1
    (00.372140)     Unseizing 17558 into 1
    (00.372196) Error (cr-dump.c:1631): Dumping FAILED.
    
    ...which is hard to debug.
    Signed-off-by: 's avatarTycho Andersen <tycho.andersen@canonical.com>
    Signed-off-by: 's avatarPavel Emelyanov <xemul@parallels.com>
    b6a355c3
Name
Last commit
Last update
Documentation Loading commit data...
arch Loading commit data...
contrib Loading commit data...
include Loading commit data...
lib Loading commit data...
pie Loading commit data...
protobuf Loading commit data...
pycriu Loading commit data...
scripts Loading commit data...
test Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
Makefile.config Loading commit data...
Makefile.crtools Loading commit data...
Makefile.inc Loading commit data...
README.md Loading commit data...
action-scripts.c Loading commit data...
aio.c Loading commit data...
bfd.c Loading commit data...
cgroup.c Loading commit data...
cr-check.c Loading commit data...
cr-dedup.c Loading commit data...
cr-dump.c Loading commit data...
cr-errno.c Loading commit data...
cr-exec.c Loading commit data...
cr-restore.c Loading commit data...
cr-service.c Loading commit data...
cr-show.c Loading commit data...
crit Loading commit data...
crtools Loading commit data...
crtools.c Loading commit data...
eventfd.c Loading commit data...
eventpoll.c Loading commit data...
fault-injection.c Loading commit data...
fifo.c Loading commit data...
file-ids.c Loading commit data...
file-lock.c Loading commit data...
files-ext.c Loading commit data...
files-reg.c Loading commit data...
files.c Loading commit data...
fsnotify.c Loading commit data...
image-desc.c Loading commit data...
image.c Loading commit data...
ipc_ns.c Loading commit data...
irmap.c Loading commit data...
kcmp-ids.c Loading commit data...
kerndat.c Loading commit data...
libnetlink.c Loading commit data...
log.c Loading commit data...
lsm.c Loading commit data...
mem.c Loading commit data...
mount.c Loading commit data...
namespaces.c Loading commit data...
net.c Loading commit data...
netfilter.c Loading commit data...
page-pipe.c Loading commit data...
page-read.c Loading commit data...
page-xfer.c Loading commit data...
pagemap-cache.c Loading commit data...
parasite-syscall.c Loading commit data...
pipes.c Loading commit data...
plugin.c Loading commit data...
proc_parse.c Loading commit data...
protobuf-desc.c Loading commit data...
protobuf.c Loading commit data...
pstree.c Loading commit data...
ptrace.c Loading commit data...
rbtree.c Loading commit data...
rst-malloc.c Loading commit data...
sd-daemon.c Loading commit data...
sd-daemon.h Loading commit data...
security.c Loading commit data...
seize.c Loading commit data...
shmem.c Loading commit data...
sigframe.c Loading commit data...
signalfd.c Loading commit data...
sk-inet.c Loading commit data...
sk-netlink.c Loading commit data...
sk-packet.c Loading commit data...
sk-queue.c Loading commit data...
sk-tcp.c Loading commit data...
sk-unix.c Loading commit data...
sockets.c Loading commit data...
stats.c Loading commit data...
string.c Loading commit data...
sysctl.c Loading commit data...
sysfs_parse.c Loading commit data...
timerfd.c Loading commit data...
tty.c Loading commit data...
tun.c Loading commit data...
util.c Loading commit data...
uts_ns.c Loading commit data...
vdso.c Loading commit data...