• Dmitry Safonov's avatar
    x86/kdat: Check PTRACE_TRACEME return value · ce437d3d
    Dmitry Safonov authored
    Coverity has informed:
    
    *** CID 188251:  Error handling issues  (CHECKED_RETURN)
    /criu/arch/x86/crtools.c: 196 in kdat_x86_has_ptrace_fpu_xsave_bug_child()
    190             return 0;
    191     }
    192     #endif
    193
    194     static int kdat_x86_has_ptrace_fpu_xsave_bug_child(void *arg)
    195     {
    >>>     CID 188251:  Error handling issues  (CHECKED_RETURN)
    >>>     Calling "ptrace" without checking return value (as is done elsewhere 46 out of 51 times).
    196             ptrace(PTRACE_TRACEME, 0, 0, 0);
    197             kill(getpid(), SIGSTOP);
    198             pr_err("Continue after SIGSTOP.. Urr what?\n");
    199             _exit(1);
    200     }
    201
    
    Also added checks for kill() and waitpid().
    Signed-off-by: 's avatarDmitry Safonov <dima@arista.com>
    Signed-off-by: 's avatarAndrei Vagin <avagin@virtuozzo.com>
    ce437d3d
Name
Last commit
Last update
Documentation Loading commit data...
compel Loading commit data...
contrib Loading commit data...
coredump Loading commit data...
crit Loading commit data...
criu Loading commit data...
images Loading commit data...
include/common Loading commit data...
lib Loading commit data...
scripts Loading commit data...
soccr Loading commit data...
test Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
INSTALL.md Loading commit data...
Makefile Loading commit data...
Makefile.compel Loading commit data...
Makefile.config Loading commit data...
Makefile.install Loading commit data...
Makefile.versions Loading commit data...
README.md Loading commit data...