- 04 Apr, 2016 5 commits
-
-
Tycho Andersen authored
Consider when there is a double fork of helpers or zombies, e.g. when a zombie has a session id which doesn't match its pid. If the child dies and exits before the grandchild, the grandchild reparents to init, and when the task dies init doesn't have it in the helper list, so init dies as well, viz. the log below. (00.118789) Add a helper 293 for restoring SID 293 (00.118792) Attach 294 to the temporary task 293 ... (01.394403) 294: Restoring zombie with 0 code ... pie: Task 294 exited, status= 0 (01.434279) Error (cr-restore.c:1308): 12097 killed by signal 19 (01.434420) Error (cr-restore.c:1308): 12097 killed by signal 19 (01.450258) Switching to new ns to clean ghosts (01.450324) Error (cr-restore.c:2138): Restoring FAILED. Let's have the helpers reap their children before they exit to avoid this. v2: block SIGCHLD when waiting on helpers so that it doesn't race with the SICGHLD handler v3: * only helpers should collect their children, zombies can't have kids * don't double decrement nr_tasks in zombie case Signed-off-by:Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by:
Pavel Emelyanov <xemul@virtuozzo.com>
-
Pavel Emelyanov authored
Signed-off-by: -
Mike Rapoport authored
The following error happens when building CRIU on Fedora 22: CC autofs.o autofs.c: In function ‘autofs_mount’: autofs.c:892:9: error: implicit declaration of function ‘add_post_prepare_cb’ [-Werror=implicit-function-declaration] ret = add_post_prepare_cb(autofs_add_mount_info, mi); ^ cc1: all warnings being treated as errors Adding forward declaration of add_post_prepare_cb resolves the issue. Signed-off-by:Mike Rapoport <rapoport@il.ibm.com> Signed-off-by:
-
Stanislav Kinsburskiy authored
Signed-off-by:
Stanislav Kinsburskiy <skinsbursky@virtuozzo.com> Signed-off-by:
-
Stanislav Kinsburskiy authored
Autofs restore needs to create some shared data structures to be able to pass data to actual autofs master. But on mount restore stage shared data is not configured yet. This list of objects and their actors is processed after all mounts and shared data are restored to let autofs to create the objects. Signed-off-by:
-
- 01 Apr, 2016 15 commits
-
-
Tycho Andersen authored
Before the nsroot= mount option, we were just getting lucky because the cgroup superblocks "matched" when inspecting them from userspace, so we were actually getting a bind mount from the host when migrating from within cgroup namespaces. Instead, let's actually do a new (i.e. not a bind mount) for cgroup namespaces. For this, we need two things: 1. to prepare the cgroup namespace (and thus the cgroups) before the mount ns, so when the mount() occurrs it is relative to the right cgroup path. 2. not reject cgroup filesystems with no root. A cgroup ns mount looks like: 223 222 0:22 /lxc/unpriv /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup cgroup rw,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd,nsroot=/lxc/unpriv i.e. it has /lxc/unpriv as its root, and thus doesn't look rooted to CRIU. We use the fstype->parse hook to rewrite this root to /, since it is handled by the cgroup ns infrastructure. v2: add new fstype->munge hook, allowing fstypes to munge their parsed mountinfo entries if they want to. this allows us to get rid of the ugly hacks with FSTYPE__CGROUP everywhere in teh patch. v3: s/fstype->munge/fstype->parse for FSTYPE__CGROUP Signed-off-by: -
Dmitry Safonov authored
The target has been broken for some time without complaints from users. https://lists.openvz.org/pipermail/criu/2016-March/026525.html Cc: Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
Dmitry Safonov <dsafonov@virtuozzo.com> Acked-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Cyrill Gorcunov authored
To link dynamic libs (libcompel for example). Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Don't forget to call objectify. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
No much point in carrying it in a separate file. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
These tests check for file descriptor being assigned to the pid which is freed already, so check them in PID namespace only, otherwise the kernel may give PID someone else and the check from commit c4cf5f0b might trigger and stop testing procedure. Signed-off-by:
-
Dmitry Safonov authored
Before this would open file named '-' as log: ./criu/criu dump -t 20526 -o - But now it will print log into stdout. Charming. Signed-off-by:
-
Andrew Vagin authored
v2: set umask to 0000. It's required to generate gcda, gcno files Signed-off-by:
Andrew Vagin <avagin@virtuozzo.com> Signed-off-by:
-
Dmitry Safonov authored
Where it's possible to use glibc. Signed-off-by:
-
- 25 Mar, 2016 20 commits
-
-
Andrei Vagin authored
We need to adjust free_bytes each time when we change free_bytes. Fixes #140 Signed-off-by:
-
Sergey Bronnikov authored
- option --keep-going is not mandatory if we run a single testcase - show warning when we use --keep-going with a custom set of testcases - ignore --keep-going when we run a custom set of testcase (exit on 1st fail) Signed-off-by:
Sergey Bronnikov <sergeyb@openvz.org> Signed-off-by:
-
Cyrill Gorcunov authored
In commit 9469dae61c we've dropped implicit cleanups as a pattern but in images dir we use additional custom rules so simply drop files built. Signed-off-by:
-
Pavel Emelyanov authored
Sometimes when running tests manually it's tempting to prepare the list of tests to run in advance and then run only those. E.g. -- when testing a new feature that affects only _some_ tests. This option allows it. Signed-off-by: -
Cyrill Gorcunov authored
A typo. Signed-off-by:
-
Cyrill Gorcunov authored
If makefile is changed itself we've been not detecting it. Signed-off-by:
-
Tycho Andersen authored
Later (find_ext_ns_id, but probably others as well) we depend on the struct being zeroed in order to figure out whether or not to collect info about it. Let's make sure it is actually zeroed. Signed-off-by:
-
Tycho Andersen authored
See comment for details, but basically this mountopt can be completely wrong in some cases. Signed-off-by:
-
Cyrill Gorcunov authored
With cleanify helper we remove only they files we've been generating, not anything else. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Both never worked, we need to pass them as explicit parameter. Signed-off-by:
-
Dmitry Safonov authored
Each time I type `make clean` and find that my tags are cleaned and generated headers/c-files are deleted, I'm getting annoyed. Mostly it's about protobuf images definitions. (And then I need to run `make` and `make tags` again which is painful). I think, we may separate clean process on two parts, just like it's done in the kernel (omitting distclean): o Cleaning all binaries/objects, but leave enough to navigate o Clean everything compiled/generated/etc. In this patch pie blobs are still deleted on clean stage - I may fix it in the later patches. (they _should_ be regenerated on `make clean && make`) Cc: Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Dmitry Safonov authored
This will separate clean process on two parts: - deleting binaries/objects/temp - deleting generated files Cc: Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Andrew Vagin authored
------------------------ grep Error ------------------------ (00.011453) Error (files-reg.c:1136): Can't lookup mount=85 for fd=3 path=/var/lib/jenkins/workspace/CRIU-inhfd/test/report/criu-testreport.tap (00.011478) Error (cr-dump.c:1304): Dump files (pid: 4) failed with -1 (00.011903) Error (cr-dump.c:1606): Dumping FAILED. ------------------------ ERROR OVER ------------------------ Cc: Sergey Bronnikov <sergeyb@openvz.org> Fixes: c4e13bc92816 ("zdtm.py: add support of test reports in TAP format") Signed-off-by: -
Andrew Vagin authored
+ ./test/zdtm.py run --all -f best -x maps04 -x cgroup02 --norst --keep always usage: CRIU test suite run [-h] [-a] [-t TEST] [-T TESTS] [-f FLAVOR] [-x EXCLUDE] [--sibling] [--pre PRE] [--snaps] [--dedup] [--nocr] [--norst] [--iters ITERS] [--fault FAULT] [--sat] [--sbs] [--freezecg FREEZECG] [--user] [--page-server] [-p PARALLEL] [--dry-run] [-k {always,never,failed}] [--report REPORT] [--keep-going] CRIU test suite run: error: ambiguous option: --keep could match --keep-img, --keep-going It worked fine without the --keep-going option. [xemul: Remove the --keep-going and --report options, the run of zdtm.py is not of much interest for TAP ] Signed-off-by: -
Sergey Bronnikov authored
It was requested by Andrey. This patch adds details about failed testcase to a TAP report: TAP version 13 1..1 not ok 1 - zdtm/static/deleted_unix_sock # flavor h Signed-off-by:
-
