- 05 Nov, 2014 12 commits
-
-
Andrey Vagin authored
CID 73354 (#1 of 1): Resource leak (RESOURCE_LEAK) 9. leaked_handle: Handle variable sock going out of scope leaks the handle Signed-off-by:
Andrey Vagin <avagin@openvz.org> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
Andrey Vagin authored
list_for_each_entry_safe() should be used, you we are going to delete something from a list. CID 73383 (#1 of 1): Read from pointer after free (USE_AFTER_FREE) 4. deref_after_free: Dereferencing freed pointer prop. Cc: Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by:
Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by:
-
Andrey Vagin authored
This function doesn't allocate memory, so it should not release it. CID 73380 (#1 of 1): Use after free (USE_AFTER_FREE) 14. deref_arg: Calling munmap dereferences freed pointer addr. Signed-off-by:
-
Andrey Vagin authored
CID 73379 (#1 of 1): Use after free (USE_AFTER_FREE) 31. deref_arg: Calling fclose dereferences freed pointer fp. Signed-off-by:
-
Andrey Vagin authored
CID 73348 (#1 of 1): Resource leak (RESOURCE_LEAK) 19. leaked_handle: Handle variable sk going out of scope leaks the handle. Signed-off-by:
-
Andrey Vagin authored
When a process, which starts a service, exits, we know that we can connect to the page server and we expect to find pidfile. If we create pidfile from a page server process, we have a race window. Signed-off-by:
-
Andrey Vagin authored
CID 73381 (#1 of 1): Out-of-bounds write (OVERRUN) 15. overrun-local: Overrunning array loc_buf of 4096 bytes at byte offset 4096 using index len (which evaluates to 4096). CID 73355 (#1 of 1): Out-of-bounds write (OVERRUN) 6. overrun-local: Overrunning array loc_buf of 4096 bytes at byte offset 4096 using index ret (which evaluates to 4096) Signed-off-by:
-
Pavel Emelyanov authored
Signed-off-by:
Andrew Vagin <avagin@parallels.com>
-
Pavel Emelyanov authored
Introduced by eb214be2, the empty mnt_share list cannot produce the list_first_entry element :) Signed-off-by:
-
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Cyrill Gorcunov authored
Some kernel modules such as pktgen runs kthred upon new-net creation taking last_pid we were requested. Lets workaround this problem using clone + unshare bundle. Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Acked-by:
-
- 30 Oct, 2014 13 commits
-
-
Cyrill Gorcunov authored
| tty.c: In function ‘tty_restore_ctl_terminal’: | include/criu-log.h:42:16: error: ‘index’ may be used uninitialized in this function [-Werror=maybe-uninitialized] Same time assign CONSOLE_INDEX for debug info. Signed-off-by:
-
Andrey Vagin authored
and return an error, if a proccess live in another userns, because criu doesn't support it. Signed-off-by:
-
Andrey Vagin authored
readlink() does not append a null byte to buf. Signed-off-by:
-
Andrey Vagin authored
CRIU reads /proc/pid/ns/[NS] and fails of a link is not exist. Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Pavel Emelyanov authored
When creating helpers, we need to make sure their PIDs do not intersect with threads' IDs. Signed-off-by:
-
Pavel Emelyanov authored
This is for two reasons. First, validation can meet external mount and will call plugins, which is not correct on pre-dump and actually crashes on uninitilized plugins lists. Second, even if on pre-dump mount tree is not "supported" this can be a temporary situation (yes, yes, unlikely, but still). On the other hand, it's better to fail earlier, but that's another story. Reported-by:
Sowmini Varadhan <sowmini.varadhan@oracle.com> Signed-off-by:
-
Tycho Andersen authored
The pty field here is only present with certain tty types, so we shouldn't unconditionally dereference it, or criu will hang. Signed-off-by:
-
Andrey Vagin authored
Now we check them for all test processes v2: Busybox doesn't have truncate Signed-off-by:
Christopher Covington <cov@codeaurora.org> Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Mr Jenkins reports errors like this: (02.423007) Error (bfd.c:118): Error flushing image Signed-off-by:
-
Cyrill Gorcunov authored
In case if we meet virtualized devtmpfs on dump (which means its s_dev is different from one obtained during mountpoints dump procedure) we should dump it with tar help. Thus on restore it get filled from the image. Signed-off-by:
-
Cyrill Gorcunov authored
We will need devtmpfs as well so make it general. Signed-off-by:
-
- 29 Oct, 2014 5 commits
-
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Currenlty a generated path contains two slashes successively. Signed-off-by:
-
Andrey Vagin authored
So we need to create a temporary private mount for the old root. Signed-off-by:
-
Andrey Vagin authored
We do the same action twice. It's typo. Signed-off-by:
-
Andrey Vagin authored
This reverts commit 21d1b2fd. pivot_root() can move the current root to a non-shared mount. So we are going to create a temporary private mount in put_old. Signed-off-by:
-
- 27 Oct, 2014 10 commits
-
-
Ruslan Kuprieiev authored
We have two global enums with the member TUN. The first one is in fdinfo.proto and the second one is in netdev.proto. protoc complains about having TUN in 2 global enums because of the enum rules for C++(even though we're compiling .proto files for python). So lets rename TUN into TUNF to avoid that conflict. Signed-off-by:
Ruslan Kuprieiev <kupruser@gmail.com> Signed-off-by:
-
Cyrill Gorcunov authored
We simply check that major/minor didn't changed after restore. Signed-off-by:
-
Cyrill Gorcunov authored
/dev/console is a system console which provided by the system with major 5 and minor 1. It's usually configured on system startup with console= option and underlied driver is resposible to deliver messages to the console user. Signed-off-by:
-
Andrey Vagin authored
The parasite daemon set up SIGCHLD handler, but for dumping threads we use parasite-trap. While doing this the sigchild handler notices the CHLD arriving on the thread trap, emits an error (00.020292) Error (parasite-syscall.c:387): si_code=4 si_pid=3485 si_status=5 but wait() reports -1 (task is not dead, just trapped) and handler just exits. Let's stop a parasite daemon before dumping threads. Signed-off-by:
-
Andrey Vagin authored
Signed-off-by:
-
Andrey Vagin authored
Currently we fill as much as posible data in a socket and then use half of these data to make a flow in the connection. These data is send and recv buffers. When a connection is dumped and restored, it needs time to go back to the normal work. In this time we can reliably fill only send buffers. So at the result the sockets may contain less data than required for heartbeating and the test will block. The test with this patch will monitor actuall size of data in a test socket. Cc: Konstantin Neumoin <kneumoin@parallels.com> Reported-by:
Konstantin Neumoin <kneumoin@parallels.com> Signed-off-by:
-
Cyrill Gorcunov authored
@action_names is rather a const array, so make sure we never access some data outside of it defining its size. Signed-off-by:
-
Andrey Vagin authored
In addition it checks that criu closes all its descriptors Signed-off-by:
-
Cyrill Gorcunov authored
strstr is a really heavy one, lets use already defined and filled @file_path variable instead. Reported-by:
-
Cyrill Gorcunov authored
In criu we carry SysV memory via @VMA_AREA_SYSVIPC attribute but to the test must have a live reference to real memory area to check that shmem address was restored correctly. Add it. Signed-off-by:
-
