- 01 Mar, 2012 12 commits
-
-
Pavel Emelyanov authored
When seizing a task and waiting for it to stop, we can receive an event from kernel, that the task didn't stop, but caught a signal. Don't treat this as an error, let the victim handle it and proceed. The transition/fork test should work OK now. Signed-off-by:
Pavel Emelyanov <xemul@parallels.com> Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org>
-
Pavel Emelyanov authored
Empty list on scan error means, that the very top task ran away from us. There's no point in trying to catch one. Signed-off-by:
-
Pavel Emelyanov authored
This can happen while dumping a pid-namespace (we can't do it now), thus put this check not to forget one in the future. Signed-off-by:
-
Pavel Emelyanov authored
Tasks can fork or die while we try to seize them. It's much more simpler and much more reliably to unseize what was seized and walk the tree again in case of some tree check failed. Yes, this makes it impossible to suspend a big tree which constantly forks :( but I'd prefer fixing more urgent issues before. Signed-off-by:
-
Pavel Emelyanov authored
Remove CR_TASK_XXX states, use the TASK_XXX ones (for image). This is required to unseize tasks properly in the next patches. Plus, make sure that pstree_list and the seized set coincide (i.e. handle error in collect_task). Signed-off-by:
-
Pavel Emelyanov authored
When we've seized all the tasks and threads found in /proc check for the /proc contents be the same. Do it one-by-one as we descend the tree. This is OK, since tasks cannot create kids for anyone but themselves or their parents (reparent will be handled later). Signed-off-by:
-
Pavel Emelyanov authored
It's in item already. Signed-off-by:
-
Pavel Emelyanov authored
While we try to seize task it can die and give its pid to somebody else. This can break pstree consistency. Check for parent being valid after task is seized. Signed-off-by:
-
Pavel Emelyanov authored
Move proc checks for Z-state into seize_task(). Signed-off-by:
-
Pavel Emelyanov authored
Merge two calls into one helper. For future. Signed-off-by:
-
Pavel Emelyanov authored
Signals shouldn't come to parasite after we've blocked them. Signed-off-by:
-
Kinsbursky Stanislav authored
Without the patch all files starting with "." will be ommited. Use of strcmp() - explicit check for "." and ".." looks clearer. Signed-off-by:
Stanislav Kinsbursky <skinsbursky@openvz.org> Acked-by:
-
- 29 Feb, 2012 12 commits
-
-
Cyrill Gorcunov authored
- drop double file-ids.h inclusion - rename fd_id_entry to plain entry, it's used just in a couple of lines only, no need for complex name Reported-by:
Kir Kolyshkin <kir@parallels.com> Signed-off-by:
-
Kinsbursky Stanislav authored
Small cleanup patch Signed-off-by:
-
Kinsbursky Stanislav authored
Signed-off-by:
-
Kinsbursky Stanislav authored
Signed-off-by:
-
Kinsbursky Stanislav authored
Based on xemul@ patches. Signed-off-by:
-
Kinsbursky Stanislav authored
Based on xemul@ patches. Signed-off-by:
-
Kinsbursky Stanislav authored
Based on xemul@ patches. Signed-off-by:
-
Kinsbursky Stanislav authored
This patch was designed to be generic and thus usable for all kinds of sockets. Not sure, thah this goal has been reached, but at least I tried. Key ideas: 1) sockets queue dump file have to be readed first and then packets entries with offset for it's data in image will be collected in doubly linked list by read_sockets_queue() function. Note: list will contain sockets queues for all (!) the sockets of the task. 2) socket queue can be restored by restore_socket_queue(), which selects packets from the list by passed id and use sendfile() top send them to the passed socket. It also removes packet from the list and frees it. Based on xemul@ patches. Signed-off-by:
-
Kinsbursky Stanislav authored
This patch was designed to be generic and thus usable for all kinds of sockets. Not sure, thah this goal has been reached, but at least I tried. Key ideas: 1) On-stack structure for collecting sockets queues and then passing them to parasite code. 2) Singly linked list is used for collecting structures, representing sockets of any kind (!) with queues. Based on xemul@ patches. Signed-off-by:
-
Kinsbursky Stanislav authored
This patch adds sockets queue dump functionality. Key ideas 1) sockets info is passed as plain array in parasite args. 2) new socket option SO_PEEK_OFF with MSG_PEEK is used to read the get the queue's packets. 3) Buffer for packet will be allocated for each socket separately and with size of socket sending buffer. For stream sockets is means, that it's queue will be dumped in chunks of this size. Note: loop around sys_msgrcv() is required for DGRAM sockets - sys_msgrcv() with MSG_PEEK will return only one packet. Based on xemul@ patches. Signed-off-by:
-
Kinsbursky Stanislav authored
This test is based on original version by xemul@ - second message to queue added. Signed-off-by:
-
Kinsbursky Stanislav authored
This is a cleanup patch. Signed-off-by:
-
- 28 Feb, 2012 14 commits
-
-
Kinsbursky Stanislav authored
Signed-off-by:
-
Cyrill Gorcunov authored
We switch generic-object-id concept with sys_kcmp approach, which implies changes of image format a bit (and since it's early time for project overall, we're allowed to). In short -- previously every file descriptor had an ID generated by a kernel and exported via procfs. If the appropriate file descriptors were the same objects in kernel memory -- the IDs did match up to bit. It allows us to figure out which files were actually the identical ones and should be restored in a special way. Once sys_kcmp system call was merged into the kernel, we've got a new opprotunity -- to use this syscall instead. The syscall basically compares kernel objects and returns ordered results suitable for objects sorting in a userspace. For us it means -- we treat every file descriptor as a combination of 'genid' and 'subid'. While 'genid' serves for fast comparison between fds, the 'subid' is kind of a second key, which guarantees uniqueness of genid+subid tuple over all file descritors found in a process (or group of processes). To be able to find and dump file descriptors in a single pass we collect every fd into a global rbtree, where (!) each node might become a root for a subtree as well. The main tree carries only non-equal genid. If we find genid which is already in tree, we need to make sure that it's either indeed a duplicate or not. For this we use sys_kcmp syscall and if we find that file descriptors are different -- we simply put new fd into a subtree. Signed-off-by:
-
Cyrill Gorcunov authored
This function simply allocates shared memory. Name it so and move it closer to the variables it referes on. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
The function has nothing to do with "pop" operation, it rather "pull"s descriptor out of list. Name it so. Signed-off-by:
-
Cyrill Gorcunov authored
Having them in the header file will allow to share these structures with other callers. Moreover, this is a good practice to have definition(s) in header file until otherwise really needed. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Will be needed for file-ids handling. Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Cyrill Gorcunov authored
Though we can use libc's syscall() wrapper I would prefer to have own implementation in case if we will need it in non-libc bindable code. Signed-off-by:
-
Kinsbursky Stanislav authored
1) Use macro for defining size mapped size. 2) Allow to allocate all space (including the last byte). Signed-off-by:
-
Kinsbursky Stanislav authored
Current heap has 10 MB free space. It should be enough. Otherwise something broken by design.. Signed-off-by:
-
Kinsbursky Stanislav authored
Stack heap size is probably small for dumping unix sockest skb's (it's hard to discover, how big it could be; thus let's assume that 10MB is enough, otherwise give up and throw error). So let' replace this stack heap wil 10 MB anonimous private mapping. Signed-off-by:
-
- 27 Feb, 2012 1 commit
-
-
Kinsbursky Stanislav authored
Signed-off-by:
-
- 22 Feb, 2012 1 commit
-
-
Cyrill Gorcunov authored
Signed-off-by:
-
