- 15 Oct, 2015 2 commits
-
-
Ruslan Kuprieiev authored
As it is not recomended to run criu as a root system service, lets remove service file to stop encouraging people to do it. Signed-off-by:
Ruslan Kuprieiev <rkuprieiev@cloudlinux.com> Signed-off-by:
Pavel Emelyanov <xemul@parallels.com>
-
Tycho Andersen authored
Signed-off-by:
Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by:
-
- 14 Oct, 2015 6 commits
-
-
Andrew Vagin authored
Signed-off-by:
Andrew Vagin <avagin@openvz.org> Signed-off-by:
-
Andrew Vagin authored
Signed-off-by:
-
Laurent Dufour authored
This patch change the build chain to not use pie objects in the crtools executable. This done by building the shared source files twice: 1. for parasite/restorer as '<file>-pie-build.o' 2. for crtools as '<file>.o' Signed-off-by:
Laurent Dufour <ldufour@linux.vnet.ibm.com> Reviewed-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Cyrill Gorcunov authored
The kernel prior 4.3 is exporting FS_EVENT_ON_CHILD bit via procfs fdinfo interface. This bit is kernel's internal and should not be passed in inotify_add_watch call. Thus simply filter it out when obtain from old images for backward compatibility reason. More details here https://lkml.org/lkml/2015/9/21/680Signed-off-by:
-
Andrew Vagin authored
open_mountpoint helper is called when mount namespace are already restored so we have to use local paths. This is a continuation to patch a082f27b -- we keep mount point id in fsnotify, thus we should use the namespace's path for open. https://jira.sw.ru/browse/PSBM-39957Signed-off-by:
-
Andrew Vagin authored
If criu restore failed, criu should wait all processes because they hold files, namespaces and other stuff that caller might want to have released (in our case it was ploop device). Here we do this only for cases when processes are restored in a pid namespace. We'd like to do the same for non-ns case, but there's no simple way to wait for a bunch of unconnected processes. Another good side effect is that "Restoring FAILED." will be printed at the end of the log (now after we kill init tasks still have time to do smth and write log messages). Cc: Nikita Spiridonov <nspiridonov@odin.com> Reported-by:
Nikita Spiridonov <nspiridonov@odin.com> Signed-off-by:
-
- 12 Oct, 2015 17 commits
-
-
Andrew Vagin authored
We need to use SIG_SETMASK instead of SIG_BLOCK. SIG_SETMASK The set of blocked signals is set to the argument set. Signed-off-by: -
Andrew Vagin authored
Otherwise it's impossible to understand from which namespace this path should be opened. Signed-off-by:
-
Andrew Vagin authored
Signed-off-by:
-
Andrew Vagin authored
For slave mount we need to make sure that all childrent mountpoints of the master peer is mounted before we can proceed otherwise there gonna be duplicated mountpoints after the restore. https://jira.sw.ru/browse/PSBM-39957Signed-off-by:
Andrew Vagin <avagin@odin.com> Signed-off-by:
-
Pavel Emelyanov authored
This flag means that there's lib/ directory where a plugin is. Currently rtc test is such. The wait_pid_die timeout is risen since this test dies for more than 6 seconds :) Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Sometimes tests fail before generating .out file, so print its contents only if it exists. Signed-off-by: -
Pavel Emelyanov authored
I constantly have binfmt_misc off on my set ups :) Looks like this fs is far from being default for systems, so to make the test work (we plan to rewrite it anyway) let's make this fs being optional. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
Hand-made list of tests is not great. As Christopher suggested we can find all executables in a directory and treat them as tests. This idea is good, but requires a little bit more trickery. First, some executables in directory are not tests, e.g. these are per-test scripts, which should be skipped. Next, not all tests in zdtm can be right now run in continuous manner (they fail), but we want to run them manually. To fix that such tests are marked with 'noauto' flag in the description. So we have the test test descriptor file, which states in which file to look for tests (executable) and which of them to exclude. Maybe more, can be added on demand. And, finally, the per-test description goes in a ${test}.desc file in native python eval/repr-able format. If the file is absent a default description is used. Signed-off-by: -
Pavel Emelyanov authored
The main difficulty here is that restored test becomes zdtm.py's kid and after killing one we should wait() the test's zombie. W/o the --restore-sibling test gets restored under existing init and gets wait()-ed automagically. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
In case t.kill() raises an exception (sometimes it can) it becomes unclear what's going on. Signed-off-by: -
Pavel Emelyanov authored
Signed-off-by: -
Pavel Emelyanov authored
When test is run in pseudo-container (--parallel execution) the new namespace's init is the python script itself. Thus all dying tests get reparent-ed to it and sit as zombies forever. Create pseudo-init for such containers ripping all the children. Signed-off-by:
-
- 09 Oct, 2015 10 commits
-
-
Andrew Vagin authored
../../lib/libcriu.so: undefined reference to `strlcpy' v2: don't include string.h Reported-by: Mr Jenkins Cc: Kir Kolyshkin <kir@openvz.org> Fixes: e5654e58 ("Use strlcpy") Signed-off-by:
-
Kir Kolyshkin authored
pr_perror() is special, it adds \n at the end so there is no need to supply one. Signed-off-by:
Kir Kolyshkin <kir@openvz.org> Acked-by:
-
Kir Kolyshkin authored
In places where we have errno value set, such as after calling ptrace(), it makes sense to use pr_perror as it appends the errno string. This also fixes missing '\n' at the end (as pr_perror() adds it). In places where we keep using pr_err(), don't forget to have '\n'. Cc: Laurent Dufour <ldufour@linux.vnet.ibm.com> Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
Don't forget '\n' when using pr_err() Signed-off-by:
-
Kir Kolyshkin authored
Signed-off-by:
-
Kir Kolyshkin authored
As ptrace() sets errno, it makes sense to use pr_perror(). This also fixes the bug of missing '\n'. Signed-off-by:
-
Andrew Vagin authored
When we don't use userns, __userns_sysctl_op is called in context of the current process. A mount namespaces is restored the last one, so when we restore namespaces, we see /proc from the host pid namespace. In this case we can't use virtual pid to access /proc/pid. Let's open /proc/self/ns and use this descriptor to switch namespaces. Cc: Tycho Andersen <tycho.andersen@canonical.com> Fixes: f79f4546 ("sysctl: move sysctl calls to usernsd") Signed-off-by:
-
Adrian Reber authored
There are still systems which do not support dirty memory tracking. This offers an interface to query the dirty memory tracking availability via the new feature check RPC. This is in preparation of a p.haul change which will use this RPC interface to automatically detect if pre-dumps should be executed or not. This change introduces an additional optional field in the criu_request and criu_response message (features) which is a 'criu_features' message. Right now only the check for the memory tracking feature is supported in the message 'criu_features': optional bool mem_track = 1; v2: Instead of checking for memory tracking only, provide a generic interface to check for arbitrary features. v3: Do not use bitfields for feature encoding but protobuf optional message parameters. Signed-off-by:Adrian Reber <areber@redhat.com> Signed-off-by:
-
Matthew Krafczyk authored
This allows the user to perform actions before dumping or restoration occurs. Signed-off-by:
Matthew Krafczyk <krafczyk.matthew@gmail.com> Signed-off-by:
-
- 08 Oct, 2015 4 commits
-
-
Salvatore Bonaccorso authored
Chris Lamb <lamby@debian.org> reported in Debian that criu is not building reproducible while working on the "reproducible builds" effort [0]. [0] https://wiki.debian.org/ReproducibleBuilds [1] https://bugs.debian.org/801211Signed-off-by:
Salvatore Bonaccorso <carnil@debian.org> Acked-by:
-
Andrew Vagin authored
sys_sigaction() returns an error code Reported-by:
-
Cyrill Gorcunov authored
Namespace roots might be slave ones from another namespace roots, so we should not treat them as "always ready" for mounting but rely on general logic in can_mount_now which tests slaves relations. Signed-off-by:
-
Cyrill Gorcunov authored
When we restore sockets with relative names we change current working directory into the one provided by socket image data. This actually affects current criu state because the rest of code doesn't know about such tricks and may rely on working dir consistency. So remember the current working dir and restore it back once socket cwd operations are complete. Signed-off-by:
-
- 07 Oct, 2015 1 commit
-
-
Tycho Andersen authored
377763e5 is incorrect since we can't always chop off the last element in the buffer: Execute static/cgroup00 ./cgroup00 --pidfile=cgroup00.pid --outfile=cgroup00.out --dirname=cgroup00.test Dump 12819 (00.003514) Error (files-reg.c:624): Can't create link remap for /dev/nul. Use link-remap option. (00.003523) Error (cr-dump.c:1257): Dump files (pid: 12819) failed with -1 (00.004042) Error (cr-dump.c:1619): Dumping FAILED. WARNING: cgroup00 returned 1 and left running for debug needs Test: zdtm/live/static/cgroup00, Result: FAIL ==================================== ERROR ==================================== Test: zdtm/live/static/cgroup00, Namespace: ================================= ERROR OVER ================================= Hopefully the >= will appease coverity (instead of just a ==). Signed-off-by:
-
