- 30 Oct, 2018 40 commits
-
-
Pavel Tikhomirov authored
colon operators are there obviously by mistake instead of semicolons Signed-off-by:
Pavel Tikhomirov <ptikhomirov@virtuozzo.com> Signed-off-by:
Andrei Vagin <avagin@virtuozzo.com>
-
Pavel Tikhomirov authored
As mnt_roots always has a slash at the beginning we don't need another: (00.156035) 1: mnt: Move the root to //tmp/.criu.mntns.ZKVJHl/15-0000000000 Signed-off-by:
-
Pavel Tikhomirov authored
for i in $(find . -name "*.[ch]" -type f); do sed -i 's/\(pr_warn(".*[^n]\)\("[),]\)/\1\\n\2/' $i done Signed-off-by: -
Adrian Reber authored
In RPC mode the log_level was always reset to the default log level of 2, if no configuration file was used. This saves the log level set via RPC in opts.log_level and a configuration file can overwrite it later, but if it is only set via RPC this value is not ignored now. Signed-off-by:
Adrian Reber <areber@redhat.com> Signed-off-by:
-
Kondo, Uchio authored
Signed-off-by: -
Radostin Stoyanov authored
The -c and -f options were introduced on December 2011 with commit 485c4b50 show: Rework show procedure Added - ability to parse every single file crtools understands via magic number - dumped memory pages can be rendered in two modes -- as a simple set of pages' virtual addresses or in hexdummp fashion (via -c command line key). For example ./crtools -s -c -f pages-2557.img CR_FD_PAGES: pages-2557.img ---------------------------------------- 7fffb44ace20: 00 00 00 00 00 00 00 00 00 00 00 74 65 73 74 2f |. . . . . . . . . . . t e s t / | 7fffb44ace30: 74 65 73 74 2d 73 69 67 61 63 74 69 6f 6e 00 48 |t e s t - s i g a c t i o n . H | 7fffb44ace40: 4f 53 54 4e 41 4d 45 3d 6c 6f 63 61 6c 68 6f 73 |O S T N A M E = l o c a l h o s | 7fffb44ace50: 74 2e 6c 6f 63 61 6c 64 6f 6d 61 69 6e 00 54 45 |t . l o c a l d o m a i n . T E | The -p/--pid option was added on April 2013 with commit 73d7e283 show: Filter -D output with --pid option Show only image info relevant to given pid. Also reuse the introduced --pid argument for exec action. And the -F option was introduced on December 2013 with commit 7ab8a326 show: Implement simple images filtering The -F|--fields option specifies which fields (by name, comma separated) should be printed. For nested fields all names in path should be specified. All four options were used in combination with the deprecated --show command which has been decommissioned on February 2016 with commit a501b480 show: Remove deprecated code The 'show' action has been deprecated since 1.6, let's finally drop it. The print_data() routine is kept for yet another (to be deprecated too) feature called 'criu exec'. Signed-off-by:
Radostin Stoyanov <rstoyanov1@gmail.com> Acked-by:
-
Cyrill Gorcunov authored
To handle message addresses and ucreds. Signed-off-by:
Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by:
-
Cyrill Gorcunov authored
Signed-off-by:
-
Radostin Stoyanov authored
Signed-off-by:
-
Mike Rapoport authored
Fixes cov 191305 Signed-off-by:
Mike Rapoport <rppt@linux.vnet.ibm.com> Signed-off-by:
-
Andrei Vagin authored
It fails too often and nobody knows how to fix it. Signed-off-by: -
Andrei Vagin authored
>>> CID 164715: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 16 bytes on destination array "thread_args[i].comm" of size 16 bytes might leave the destination string unterminated. 3473 strncpy(thread_args[i].comm, core->tc->comm, TASK_COMM_LEN); Signed-off-by:
-
Radostin Stoyanov authored
When zdtm.py is executed with `list` sub-command the 'criu_bin' option is not defined and criu.available() fails. $ python test/zdtm.py list Traceback (most recent call last): File "test/zdtm.py", line 2243, in <module> criu.available() File "test/zdtm.py", line 1185, in available if not os.access(opts['criu_bin'], os.X_OK): KeyError: u'criu_bin' However, we don't need to check the existence of criu_bin unless we use the `run` action. Signed-off-by: -
Radostin Stoyanov authored
Signed-off-by:
-
Cyrill Gorcunov authored
It is especially important when accessing a hash -- there must be no negative indices ever. https://jira.sw.ru/browse/PSBM-82945Signed-off-by:
Cyrill Gorcunov <gorcunov@virtuozzo.com> Signed-off-by:
-
Radostin Stoyanov authored
Most of the typos were found by codespell. Signed-off-by:
-
Radostin Stoyanov authored
There are no functional changes. Signed-off-by:
-
Adrian Reber authored
Signed-off-by:
-
Alice Frosi authored
Signed-off-by:
Alice Frosi <alice@linux.vnet.ibm.com> Signed-off-by:
-
Andrei Vagin authored
Signed-off-by: -
Pavel Tikhomirov authored
In commit 23b76949 ("dump: optimize dead_pid_conflict by searching in rbtree") we'd replaced for_each_pstree_item and thread walk search with pstree_pid_by_virt (rb-tree search). The latter already found us the thread with conflicting pid if it exists, the only thing left is to skip if the thread is also a main thread of the thread group (as it was before patch). But some leftover left which checks something wrong: we index ->threads array with "i", but "i" is not a number of the thread it is a number of current dead pid. Not sure if it helps with the initial bug and duplicates, but it might: https://jira.sw.ru/browse/PSBM-55217Signed-off-by:
-
Pawel Stradomski authored
This can happen when running in user namespace with auto-dedup enabled. Right now this means auto-dedup gets disabled. Signed-off-by:
Pawel Stradomski <pstradomski@google.com> Signed-off-by:
-
Pavel Tikhomirov authored
call variables of type RemapFilePathEntry - "rpe" everywhere, similar as we already name them in oher places while on it remove unused second argument of open_remap_linked Signed-off-by:
-
Andrei Vagin authored
./test//zdtm.py --set inhfd run --all --rpc Cc: Adrian Reber <areber@redhat.com> Signed-off-by: -
Pavel Tikhomirov authored
After running criu test, docker on the node becomes unusable, as it is confused by our leftover cgroups. Surely docker should be fixed to ignore custom cgroups (https://github.com/moby/moby/issues/37601), but we should not leave them after test also. v2: rmdir the holder only if it exists, remove racy wait and remove wrongly added cleanup method in class criu v3: bring back missed semicolon Signed-off-by:
-
Cyrill Gorcunov authored
When checkpointing applications with really big memory slab (like in our vz7 test with 920G of memory) the int type get cutted, we should use long int instead, just like we do in other code pieces. Otherwise get | pie: 756: Daemon waits for command | (01.193097) Wait for ack 12 on daemon socket | (01.193112) Fetched ack: 12 12 0 | (01.193164) 988065 fdinfo 0: pos: 0 flags: 100002/0 | (01.193201) fdinfo: type: 0xb flags: 0100002/0 pos: 0 fd: 0 | (01.193279) 988065 fdinfo 1: pos: 0 flags: 100002/0 | (01.193307) fdinfo: type: 0xb flags: 0100002/0 pos: 0 fd: 1 | (01.193341) 988065 fdinfo 2: pos: 0 flags: 100002/0 | (01.193365) fdinfo: type: 0xb flags: 0100002/0 pos: 0 fd: 2 | (01.193375) ---------------------------------------- | (01.193405) Error (criu/parasite-syscall.c:243): BUG at criu/parasite-syscall.c:243 | pie: 756: Error (criu/pie/parasite.c:676): Trimmed message received (1> Signed-off-by:
-
Cyrill Gorcunov authored
In case if pipe buffers are full the splicing may wakeup reader first with incomplete data transfer. Thus splice data in cycle. Signed-off-by:
-
Pavel Tikhomirov authored
05:57:35.640: 1238: FAIL: fork.c:80: Task 16275 didn't exit (errno = 10 (No child processes)) There is no info about the killing signal in logs, add it. https://jira.sw.ru/browse/PSBM-87579Signed-off-by:
-
Cyrill Gorcunov authored
Integer is too small for big memory slabs. Signed-off-by:
-
Pavel Tikhomirov authored
Signed-off-by: -
Mike Rapoport authored
Signed-off-by: -
Mike Rapoport authored
Signed-off-by: -
Mike Rapoport authored
The stack pointers will be later use by the memory dump to ensure that current stack pages are not treated as lazy. Signed-off-by: -
Mike Rapoport authored
Currently parasite_thread_ctl for non-leader threads is initialized after we stop the compel daemon. Moving this initialization earlier will allow us to make stack pointers of all threads available during memory dump. Signed-off-by: -
Mike Rapoport authored
Signed-off-by: -
Mike Rapoport authored
We need to know what are stack pointers of every thread to ensure that the current stack page will not be treated as lazy. Signed-off-by:
Laurent Dufour <ldufour@linux.vnet.ibm.com>
-
Adrian Reber authored
Signed-off-by:
-
Adrian Reber authored
This is obviously not a real check. This only exists, so that CRIU clients/users can check if this CRIU version supports the external network namespace feature. Theoretically the CRIU client or user could also parse the version, but especially for CLI users version comparison in the shell is not easy. This feature check does not exist for RPC as RPC has a special version call which does not require string parsing and the external network namespace feature is available for all CRIU versions newer than 3.9. Signed-off-by:
-
Radoslaw Burny authored
Since the processes and fds are restored from images in the increasing order, and they are stored in sorted lists, CRIU always needed (at least in my experiments) to traverse the whole list before inserting them. With this change, lists are traversed in reverse, so the fds should be inserted immediately. Acked-by:
Kirill Tkhai <ktkhai@virtuozzo.com> Signed-off-by:
Radoslaw Burny <rburny@google.com> Signed-off-by:
-
Adrian Reber authored
The latest patches to cr-service.c broke compilation with gcc-8: criu/cr-service.c: In function ‘setup_opts_from_req’: criu/cr-service.c:323:3: error: ‘strncpy’ specified bound 4096 equals destination size [-Werror=stringop-truncation] strncpy(images_dir_path, opts.imgs_dir, PATH_MAX); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ criu/cr-service.c:343:3: error: ‘strncpy’ specified bound 4096 equals destination size [-Werror=stringop-truncation] strncpy(work_dir_path, opts.work_dir, PATH_MAX); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors This fixes the errors by specifying the strncpy() size as 'PATH_MAX - 1'. Signed-off-by:
-
